Feature/39265 Execution History Pagination Feature #3852
Conversation
WalkthroughThe recent updates to the Ginger project significantly enhance its functionality and user experience by integrating GraphQL for data retrieval, expanding UI elements, and refining existing code structures. Key improvements include a robust execution history management system, new GraphQL client extensions, and additional enumerations, all aimed at delivering a more intuitive and efficient application. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UI as RunSetsExecutionHistoryPage
participant GraphQLClient as GraphQL Client
participant API as Remote API
User->>UI: Request Execution History
UI->>GraphQLClient: Fetch Data
GraphQLClient->>API: Execute GraphQL Query
API-->>GraphQLClient: Return Execution Data
GraphQLClient-->>UI: Send Execution History
UI-->>User: Display Execution History
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
Outside diff range, codebase verification and nitpick comments (3)
Ginger/GingerCoreNET/Run/GingerRemoteExecutionUtils.cs (1)
Change of access modifier for GetReportHTMLServiceUrl is unnecessary.
The method
GetReportHTMLServiceUrlis only used within theGingerRemoteExecutionUtilsclass. There is no justification for changing its access modifier fromprivatetopublic.
Ginger/GingerCoreNET/Run/GingerRemoteExecutionUtils.csAnalysis chain
Line range hint
145-152: Change of access modifier for GetReportHTMLServiceUrl is acceptable, but verify necessity.The change from
privatetopublicis acceptable. Ensure that this change is necessary and does not introduce any security or encapsulation issues.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the necessity of making `GetReportHTMLServiceUrl` public. # Test: Search for the method usage. Expect: Usage outside the class justifies the change. rg --type cs -A 5 $'GetReportHTMLServiceUrl'Length of output: 1296
Ginger/Ginger/UserControlsLib/ucGridView/ucGrid.xaml.cs (2)
1178-1178: Add documentation for the method.Consider adding a summary comment to describe the purpose and usage of the
AddRadioButtonmethod./// <summary> /// Adds a RadioButton to the toolbar with specified properties. /// </summary> /// <param name="content">The content of the RadioButton.</param> /// <param name="name">The name of the RadioButton.</param> /// <param name="groupName">The group name for the RadioButton.</param> /// <param name="handler">The click event handler for the RadioButton.</param> /// <param name="isEnabled">Indicates whether the RadioButton is enabled.</param> /// <param name="isChecked">Indicates whether the RadioButton is checked.</param> /// <returns>The created RadioButton.</returns> public RadioButton AddRadioButton(string content, string name, string groupName, RoutedEventHandler? handler, bool isEnabled = true, bool isChecked = false)
1179-1206: Ensure consistent styling and alignment.The method is well-structured, but consider aligning the properties for better readability.
DockPanel pnl = new DockPanel { HorizontalAlignment = HorizontalAlignment.Left, VerticalAlignment = VerticalAlignment.Center, LastChildFill = false }; RadioButton b = new RadioButton { Margin = new Thickness(3, 0, 0, 0), Height = Double.NaN, Width = Double.NaN, HorizontalAlignment = HorizontalAlignment.Right, VerticalAlignment = VerticalAlignment.Center, Padding = new Thickness(2, 0, 0, 0), Content = content, GroupName = groupName, IsEnabled = isEnabled, IsChecked = isChecked, Name = name }; if (handler != null) { b.AddHandler(RadioButton.ClickEvent, handler); } pnl.Children.Add(b); toolbar.Items.Add(pnl); return b;
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (20)
- Ginger/Ginger/Ginger.csproj (1 hunks)
- Ginger/Ginger/Run/RunSetsExecutionsHistoryPage.xaml (2 hunks)
- Ginger/Ginger/Run/RunSetsExecutionsHistoryPage.xaml.cs (15 hunks)
- Ginger/Ginger/RunSetPageLib/NewRunSetPage.xaml.cs (1 hunks)
- Ginger/Ginger/SolutionWindows/SolutionPage.xaml (2 hunks)
- Ginger/Ginger/SolutionWindows/SolutionPage.xaml.cs (3 hunks)
- Ginger/Ginger/UserControlsLib/ImageMakerLib/ImageMakerControl.xaml.cs (1 hunks)
- Ginger/Ginger/UserControlsLib/ucGridView/ucGrid.xaml.cs (1 hunks)
- Ginger/GingerCoreCommon/EnumsLib/eImageType.cs (1 hunks)
- Ginger/GingerCoreCommon/EnumsLib/eStatus.cs (2 hunks)
- Ginger/GingerCoreCommon/ReporterLib/UserMsgsPool.cs (2 hunks)
- Ginger/GingerCoreNET/Clients/Extentions/GraphQLClientExtensions.cs (1 hunks)
- Ginger/GingerCoreNET/Clients/GraphQLClients/ExecutionReportGraphQLClient.cs (1 hunks)
- Ginger/GingerCoreNET/Clients/GraphQLClients/GraphQLClient.cs (1 hunks)
- Ginger/GingerCoreNET/GingerCoreNET - Backup.csproj (1 hunks)
- Ginger/GingerCoreNET/GingerCoreNET.csproj (2 hunks)
- Ginger/GingerCoreNET/Run/GingerRemoteExecutionUtils.cs (6 hunks)
- Ginger/GingerCoreNETUnitTest/GingerCoreNETUnitTest.csproj (1 hunks)
- Ginger/GingerTest/GingerTest.csproj (1 hunks)
- Ginger/GingerTest/Run/RunSetsExecutionsHistoryPageUnitTest.cs (1 hunks)
Additional comments not posted (64)
Ginger/GingerCoreCommon/EnumsLib/eStatus.cs (1)
37-37: Verify the usage of the new enum value.The addition of
Cancelledto theeRunStatusenum may affect control flow. Ensure that all logic handling task statuses is updated to account for this new value.Ginger/Ginger/SolutionWindows/SolutionPage.xaml (2)
5-6: Verify the necessity and correctness of the new namespace.The new namespace
usercontrols1has been added. Ensure that this namespace is necessary and correctly defined.
17-20: LGTM! Verify the functionality of the newStackPanel.The new
StackPanelorganizes the layout of user controls and labels. Ensure that it improves the UI as intended.Ginger/GingerCoreNET/Clients/GraphQLClients/GraphQLClient.cs (6)
27-31: LGTM! Verify the initialization of the client.The constructor initializes the
GraphQLHttpClientand callsResetPagination. Ensure that the client is correctly initialized.
36-41: LGTM! Verify the reset functionality.The
ResetPaginationmethod resets the pagination state. Ensure that all pagination-related properties are correctly reset.
46-49: LGTM! Verify the functionality of decreasing fetched items count.The
DecreaseFetchedItemsCountmethod decreases the count of fetched items. Ensure that it correctly handles edge cases.
54-87: LGTM! Verify the functionality of fetching runsets data and managing pagination.The
GetRunsetsmethod fetches runsets data using the provided GraphQL query and manages pagination. Ensure that it correctly fetches data, handles exceptions, and updates pagination properties.
84-87: LGTM! Verify the exception handling.The
GetRunsetsmethod catches exceptions and throws anApplicationException. Ensure that the exception handling is appropriate and provides useful information.
18-25: LGTM! Verify the usage of class-level properties.The class has several properties related to pagination and data fetching. Ensure that they are correctly defined and used within the class.
Ginger/GingerTest/Run/RunSetsExecutionsHistoryPageUnitTest.cs (8)
14-32: LGTM! Verify the coverage of the test method.The
CalculatePageRange_ShouldReturnCorrectRangeForFirstPagetest method verifies the page range calculation for the first page. Ensure that it correctly verifies the functionality and covers edge cases.
34-52: LGTM! Verify the coverage of the test method.The
CalculatePageRange_ShouldReturnCorrectRangeForNextPagetest method verifies the page range calculation for the next page. Ensure that it correctly verifies the functionality and covers edge cases.
54-72: LGTM! Verify the coverage of the test method.The
CalculatePageRange_ShouldReturnCorrectRangeForPreviousPagetest method verifies the page range calculation for the previous page. Ensure that it correctly verifies the functionality and covers edge cases.
74-92: LGTM! Verify the coverage of the test method.The
CalculatePageRange_ShouldReturnCorrectRangeForLastPagetest method verifies the page range calculation for the last page. Ensure that it correctly verifies the functionality and covers edge cases.
95-112: LGTM! Verify the coverage of the test method.The
CalculatePageNo_ShouldReturnCorrectRangeForFirstPagetest method verifies the page number calculation for the first page. Ensure that it correctly verifies the functionality and covers edge cases.
114-132: LGTM! Verify the coverage of the test method.The
CalculatePageNo_ShouldReturnCorrectRangeForPreviousPagetest method verifies the page number calculation for the previous page. Ensure that it correctly verifies the functionality and covers edge cases.
134-151: LGTM! Verify the coverage of the test method.The
CalculatePageNo_ShouldReturnCorrectRangeForNextPagetest method verifies the page number calculation for the next page. Ensure that it correctly verifies the functionality and covers edge cases.
153-170: LGTM! Verify the coverage of the test method.The
CalculatePageNo_ShouldReturnCorrectRangeForLastPagetest method verifies the page number calculation for the last page. Ensure that it correctly verifies the functionality and covers edge cases.Ginger/Ginger/Run/RunSetsExecutionsHistoryPage.xaml (5)
91-91: Addition of DockPanel is appropriate.The
DockPanelprovides a flexible layout structure, which is suitable for the pagination controls.
93-110: Addition of StackPanel for pagination controls is well-structured.The
StackPanelorganizes the pagination controls effectively. Ensure that the event handlers for the buttons and combo box are properly implemented.
111-111: Addition of ScrollViewer enhances user experience.The
ScrollViewerallows vertical scrolling of the grid content, improving usability.
118-120: Addition of Loading StackPanel is user-friendly.The
LoadingStackPanelprovides clear loading indicators, enhancing the user experience.
112-116: Renaming of Ginger:ucGrid is acceptable, but verify consistency.The renaming from
grdExecutionsHistorytoxGridExecutionsHistoryis acceptable. Ensure that all references to this grid are updated accordingly.Verification successful
Renaming of Ginger:ucGrid is consistent throughout the codebase.
The renaming from
grdExecutionsHistorytoxGridExecutionsHistoryhas been successfully updated in all relevant instances within the codebase.
- Verified in
Ginger/Ginger/Run/RunSetsExecutionsHistoryPage.xaml.cs.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all references to the renamed grid `xGridExecutionsHistory`. # Test: Search for the grid name. Expect: Only occurrences of the new name. rg --type xml --type cs -A 5 $'xGridExecutionsHistory'Length of output: 13020
Ginger/GingerCoreNET/Run/GingerRemoteExecutionUtils.cs (1)
Line range hint
95-102: Change of access modifier for GetReportDataServiceUrl is acceptable, but verify necessity.The change from
privatetopublicis acceptable. Ensure that this change is necessary and does not introduce any security or encapsulation issues.Verification successful
Change of access modifier for GetReportDataServiceUrl is justified and necessary.
The method
GetReportDataServiceUrlis used outside its original class inGinger/Run/RunSetsExecutionsHistoryPage.xaml.cs, which justifies the change fromprivatetopublic.
Ginger/Run/RunSetsExecutionsHistoryPage.xaml.csScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the necessity of making `GetReportDataServiceUrl` public. # Test: Search for the method usage. Expect: Usage outside the class justifies the change. rg --type cs -A 5 $'GetReportDataServiceUrl'Length of output: 4821
Ginger/GingerCoreCommon/EnumsLib/eImageType.cs (1)
357-358: Addition of new enumerations to eImageType is appropriate.The new enumerations
AnglesArrowLeftandAnglesArrowRightare properly defined and integrated within the enum.Ginger/GingerTest/GingerTest.csproj (1)
19-19: Ensure the new package reference is necessary and used.The new package reference
Ginger.AccountReport.Contractsversion2024.4.1has been added. Verify that this package is required and properly utilized in the project to avoid unnecessary dependencies.Ginger/Ginger/SolutionWindows/SolutionPage.xaml.cs (4)
50-50: Method name change for clarity.The method
Inithas been renamed toBindElement, which is more descriptive of its functionality. The change improves code readability.
57-57: Method name change for clarity.The method
Inithas been renamed toBindElement, which is more descriptive of its functionality. The change improves code readability.
Line range hint
62-82: Method name change and functionality enhancement.The method
Inithas been renamed toBindElement, which is more descriptive of its functionality. Additionally,xShowIDUC.Init(mSolution)has been added to initializexShowIDUCwithmSolution, enhancing the method's functionality.
153-153: Method name change for clarity.The method
Inithas been renamed toBindElement, which is more descriptive of its functionality. The change improves code readability.Ginger/GingerCoreNETUnitTest/GingerCoreNETUnitTest.csproj (1)
86-86: Ensure the new package reference is necessary and used.The new package reference
Ginger.AccountReport.Contractsversion2024.4.1has been added. Verify that this package is required and properly utilized in the project to avoid unnecessary dependencies.Verification successful
The new package reference
Ginger.AccountReport.Contractsis necessary and used.The package
Ginger.AccountReport.Contractsis extensively utilized across various files in the project, confirming its necessity.
- Files with usage:
Ginger/GingerCoreNET/Clients/GraphQLClients/ExecutionReportGraphQLClient.csGinger/GingerCoreNET/Clients/GraphQLClients/GraphQLClient.csGinger/GingerCoreNET/Clients/Extentions/GraphQLClientExtensions.csGinger/GingerCoreNET/Run/GingerExecutionEngine.csGinger/GingerCoreNET/RunLib/CLILib/CLIHelper.csGinger/GingerCoreNET/Run/GingerRemoteExecutionUtils.csGinger/GingerCoreNET/Run/RunsetExecutor.csGinger/GingerCoreNET/Run/RunListenerLib/LiteDBRepository.csGinger/GingerCoreNET/Run/RunListenerLib/TextFileRepository.csGinger/GingerCoreNET/Run/RunListenerLib/CenteralizedExecutionLogger/AccountReportExecutionLogger.csGinger/GingerCoreNET/Run/RunListenerLib/CenteralizedExecutionLogger/AccountReportApiHandler.csGinger/GingerCoreNET/Logger/WebReportGenerator.csGinger/GingerCoreNET/Run/RunListenerLib/CenteralizedExecutionLogger/AccountReportEntitiesDataMapping.csGinger/GingerCoreNET/LiteDBFolder/LiteDbReportBase.csGinger/GingerCoreCommon/Run/IGingerExecutionEngine.csGinger/GingerCoreNET/BPMN/Exportation/RunSetExecutionHistoryToBPMNExporter.csGinger/Ginger/Run/RunSetsExecutionsHistoryPage.xaml.csScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of the new package `Ginger.AccountReport.Contracts`. # Test: Search for the usage of the new package. Expect: Occurrences of classes or methods from the new package. rg --type cs --pattern 'Ginger.AccountReport.Contracts'Length of output: 467
Script:
#!/bin/bash # Description: Verify the usage of the new package `Ginger.AccountReport.Contracts`. # Test: Search for the usage of the new package. Expect: Occurrences of classes or methods from the new package. rg 'Ginger.AccountReport.Contracts' --type cs -A 5Length of output: 50
Script:
#!/bin/bash # Description: Verify the usage of specific classes or methods from the `Ginger.AccountReport.Contracts` package. # Test: Search for any classes or methods from the `Ginger.AccountReport.Contracts` package. Expect: Occurrences of specific classes or methods from the package. rg 'Ginger.AccountReport.Contracts' --type cs -A 5 rg 'AccountReport' --type cs -A 5Length of output: 113277
Ginger/Ginger/Run/RunSetsExecutionsHistoryPage.xaml.cs (8)
19-19: LGTM! Imports are necessary for the new functionality.The added imports for GraphQL and other utility classes are relevant and necessary for the new functionality introduced.
Also applies to: 30-30, 37-39, 44-44, 54-54
72-80: LGTM! Added fields are necessary for the new functionality.The added private fields for GraphQL clients, radio buttons, and buttons are relevant and necessary for the new functionality introduced.
111-115: LGTM! Constructor changes are necessary for the new functionality.The changes in the constructor to assign the GraphQL endpoint and set up event handlers are relevant and necessary for the new functionality introduced.
117-126: LGTM! Method correctly initializes the GraphQL client.The
AssignGraphQLObjectEndPointmethod correctly initializes the GraphQL client with the endpoint URL.
130-142: LGTM! Method correctly sets the radio button and loads the data.The
CheckCentralizedExecutionLoggerConfigmethod correctly sets the appropriate radio button and loads the executions history data.
146-161: LGTM! Methods correctly handle the events and load the data.The
RadioButton_RemoteandRadioButton_Localmethods correctly handle the radio button events and load the data accordingly.
166-182: LGTM! Method correctly refreshes the data.The
RefreshDataAsyncmethod correctly refreshes the data based on the selected radio button.
426-509: LGTM! Methods correctly handle data loading and pagination.The
LoadExecutionsHistoryDataGraphQlmethod and related methods correctly handle data loading and pagination using GraphQL.Ginger/Ginger/UserControlsLib/ImageMakerLib/ImageMakerControl.xaml.cs (1)
622-627: LGTM! New cases correctly handle the new image types.The new cases for
eImageType.AnglesArrowLeftandeImageType.AnglesArrowRightin theSetImagemethod are correctly implemented and handle the new image types.Ginger/GingerCoreNET/GingerCoreNET.csproj (5)
34-35: Good practice: Removed unused compile paths.Removing unused paths from the compilation process helps streamline the build process and reduce potential errors.
38-39: Good practice: Removed unused embedded resource paths.Removing unused embedded resource paths helps streamline the build process and reduce potential errors.
42-43: Good practice: Removed unusedNonepaths.Removing unused
Nonepaths helps clean up the project file and ensures that only necessary files are included in the build process.
266-266: Update package reference:Ginger.AccountReport.ContractsThe package reference
Ginger.AccountReport.Contractshas been updated from version4.2.6to2024.4.1. Ensure that this new version is compatible with the rest of the codebase and does not introduce any breaking changes.
270-274: Added new package references for GraphQL functionality.The new package references
GraphQL,GraphQL.Client, andGraphQL.Client.Serializer.Newtonsofthave been added. Ensure that these additions do not introduce any conflicts or issues with existing dependencies and that they are properly integrated into the project.Ginger/GingerCoreNET/GingerCoreNET - Backup.csproj (16)
3-8: Verify the necessity of Source Control properties.The
SccProjectName,SccProvider,SccAuxPath, andSccLocalPathproperties are set toSAK. Ensure that these are necessary for the project and correctly configured.
31-43: Ensure removed directories and files are obsolete.The
CompileandEmbeddedResourceitems forDataBaseAbstarct,GeneralLib\JSON,NewFolder1, andNewFolderdirectories are removed. Verify that these directories and their contents are obsolete and no longer needed.
46-50: Ensure removed files are obsolete.The
Compileitems forALMLib\ExternalItemField.cs,RecordingLib\ElementRecordEventArgs.cs, andRecordingLib\PageChangedEventArgs.csare removed. Verify that these files are obsolete and no longer needed.
52-110: Ensure removed DLLs and resources are obsolete.The
Noneitems for various DLLs and resources are removed. Verify that these DLLs and resources are obsolete and no longer needed.
112-234: Verify included DLLs and resources.The
ContentandEmbeddedResourceitems for various DLLs, reports, and resources are included. Ensure that these inclusions are necessary and correctly configured.
237-335: Verify package references and versions.The
PackageReferenceitems include various NuGet packages with specific versions. Ensure that these package references and versions are necessary and correctly configured.
341-347: Verify project references.The
ProjectReferenceitems include references to other projects within the solution. Ensure that these project references are necessary and correctly configured.
406-422: Verify updated compile items.The
Compileitems forProperties\Resources.Designer.cs,Resource.Designer.cs, andRosLynLib\ValueExpressionReference.csare updated. Ensure that these updates are necessary and correctly configured.
426-440: Verify updated content items.The
Contentitems for various images are updated. Ensure that these updates are necessary and correctly configured.
444-451: Verify updated embedded resources.The
EmbeddedResourceitems forProperties\Resources.resxandResource.resxare updated. Ensure that these updates are necessary and correctly configured.
456-479: Verify updated content items for images.The
Noneitems for various images are updated. Ensure that these updates are necessary and correctly configured.
480-944: Verify updated content items for reports and assets.The
Noneitems for various reports and assets are updated. Ensure that these updates are necessary and correctly configured.
945-1007: Verify updated content items for themes and styles.The
Noneitems for various themes and styles are updated. Ensure that these updates are necessary and correctly configured.
1008-1427: Verify updated content items for Ginger-Web-Client.The
Noneitems for various Ginger-Web-Client assets are updated. Ensure that these updates are necessary and correctly configured.
1430-1434: Verify included folders.The
Folderitems for various directories are included. Ensure that these inclusions are necessary and correctly configured.
1436-1439: Verify included embedded resources.The
EmbeddedResourceitem forhtmlReporter.cssis included. Ensure that this inclusion is necessary and correctly configured.Ginger/Ginger/Ginger.csproj (1)
707-707: Verify the necessity and impact of the new package reference.The new package reference to
Ginger.AccountReport.Contractsversion2024.4.1has been added. Ensure that this package is necessary for the new feature and verify its impact on the project.Ginger/Ginger/RunSetPageLib/NewRunSetPage.xaml.cs (1)
2277-2277: Verify the impact of removing the conditional block.The conditional block checking
mRunSetsExecutionsPage.AutoLoadExecutionDataand callingInitExecutionHistorySection()has been removed. Ensure this does not negatively impact the initialization of the execution history section when required.Ginger/GingerCoreCommon/ReporterLib/UserMsgsPool.cs (2)
197-199: LGTM! Enum values added correctly.The new enum values
RemoteExecutionReportFolderandRemoteExecutionHistoryEndPointare consistent with the existing code style.
883-884: LGTM! User messages added correctly.The new user messages for
RemoteExecutionReportFolderandRemoteExecutionHistoryEndPointare correctly defined and integrated into theLoadUserMsgsPoolmethod.
Ginger/GingerCoreNET/Clients/Extentions/GraphQLClientExtensions.cs
Outdated
Show resolved
Hide resolved
Ginger/GingerCoreNET/Clients/GraphQLClients/ExecutionReportGraphQLClient.cs
Outdated
Show resolved
Hide resolved
Ginger/GingerCoreNET/Clients/GraphQLClients/ExecutionReportGraphQLClient.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (10)
- Ginger/Ginger/Run/RunSetsExecutionsHistoryPage.xaml (2 hunks)
- Ginger/Ginger/Run/RunSetsExecutionsHistoryPage.xaml.cs (8 hunks)
- Ginger/Ginger/UserControlsLib/ucGridView/ucGrid.xaml.cs (1 hunks)
- Ginger/GingerCoreCommon/EnumsLib/eStatus.cs (2 hunks)
- Ginger/GingerCoreCommon/ReporterLib/UserMsgsPool.cs (2 hunks)
- Ginger/GingerCoreNET/Clients/Extentions/GraphQLClientExtensions.cs (1 hunks)
- Ginger/GingerCoreNET/Clients/GraphQLClients/ExecutionReportGraphQLClient.cs (1 hunks)
- Ginger/GingerCoreNET/Clients/GraphQLClients/GraphQLClient.cs (1 hunks)
- Ginger/GingerCoreNET/GingerCoreNET.csproj (2 hunks)
- Ginger/GingerTest/Run/RunSetsExecutionsHistoryPageUnitTest.cs (1 hunks)
Files skipped from review as they are similar to previous changes (10)
- Ginger/Ginger/Run/RunSetsExecutionsHistoryPage.xaml
- Ginger/Ginger/Run/RunSetsExecutionsHistoryPage.xaml.cs
- Ginger/Ginger/UserControlsLib/ucGridView/ucGrid.xaml.cs
- Ginger/GingerCoreCommon/EnumsLib/eStatus.cs
- Ginger/GingerCoreCommon/ReporterLib/UserMsgsPool.cs
- Ginger/GingerCoreNET/Clients/Extentions/GraphQLClientExtensions.cs
- Ginger/GingerCoreNET/Clients/GraphQLClients/ExecutionReportGraphQLClient.cs
- Ginger/GingerCoreNET/Clients/GraphQLClients/GraphQLClient.cs
- Ginger/GingerCoreNET/GingerCoreNET.csproj
- Ginger/GingerTest/Run/RunSetsExecutionsHistoryPageUnitTest.cs
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- Ginger/Ginger/Run/RunSetsExecutionsHistoryPage.xaml.cs (8 hunks)
- Ginger/GingerCoreNET/Clients/GraphQLClients/ExecutionReportGraphQLClient.cs (1 hunks)
- Ginger/GingerCoreNET/Clients/GraphQLClients/GraphQLClient.cs (1 hunks)
Files skipped from review as they are similar to previous changes (3)
- Ginger/Ginger/Run/RunSetsExecutionsHistoryPage.xaml.cs
- Ginger/GingerCoreNET/Clients/GraphQLClients/ExecutionReportGraphQLClient.cs
- Ginger/GingerCoreNET/Clients/GraphQLClients/GraphQLClient.cs
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- Ginger/Ginger/Run/RunSetsExecutionsHistoryPage.xaml.cs (8 hunks)
- Ginger/GingerCoreNET/Clients/GraphQLClients/ExecutionReportGraphQLClient.cs (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- Ginger/Ginger/Run/RunSetsExecutionsHistoryPage.xaml.cs
- Ginger/GingerCoreNET/Clients/GraphQLClients/ExecutionReportGraphQLClient.cs
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- Ginger/Ginger/Run/RunSetsExecutionsHistoryPage.xaml.cs (8 hunks)
- Ginger/GingerCoreNET/Clients/GraphQLClients/GraphQLClient.cs (1 hunks)
Files skipped from review due to trivial changes (1)
- Ginger/GingerCoreNET/Clients/GraphQLClients/GraphQLClient.cs
Files skipped from review as they are similar to previous changes (1)
- Ginger/Ginger/Run/RunSetsExecutionsHistoryPage.xaml.cs
| @@ -738,7 +743,7 @@ private void GetExecutionResultsFolder(object sender, RoutedEventArgs e) | |||
| { | |||
|
|
|||
|
|
|||
| if (remoteRadioButton.IsChecked == true) | |||
| if ((bool)remoteRadioButton.IsChecked) | |||
There was a problem hiding this comment.
why we need to cast it as bool if its already boolean?
Thank you for your contribution.
Before submitting this PR, please make sure:
Summary by CodeRabbit
New Features
Bug Fixes
Chores