Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced to rename existing driver in case of mismatch so Selenium wi… #3276

Merged
merged 7 commits into from
Nov 1, 2023

Conversation

Maheshkale447
Copy link
Contributor

…ll update the browser in its cache foler

Thank you for your contribution.
Before submitting this PR, please make sure:

  • PR description and commit message should describe the changes done in this PR
  • Verify the PR is pointing to correct branch i.e. Release or Beta branch if the code fix is for specific release , else point it to master
  • Latest Code from master or specific release branch is merged to your branch
  • No unwanted\commented\junk code is included
  • No new warning upon build solution
  • Code Summary\Comments are added to my code which explains what my code is doing
  • Existing unit test cases are passed
  • New Unit tests are added for your development
  • Sanity Tests are successfully executed for New and Existing Functionality
  • Verify that changes are compatible with all relevant browsers and platforms.
  • After creating pull request there should not be any conflicts
  • Resolve codacy comments
  • Builds and checks are passed before PR is sent for review
  • Resolve code review comments
  • Help Libray document is updated accordingly for Feature changes.

@JinendraGhodke
Copy link
Member

@Maheshkale447 Let's merge it to master, because we already completed lot of testing for the release.
And we never know what other issues this will bring with it.

@Maheshkale447 Maheshkale447 changed the base branch from Releases/Official-Release to master October 9, 2023 06:22
@Maheshkale447
Copy link
Contributor Author

Ok, Changed the Target branch to master

@Maheshkale447 Maheshkale447 merged commit 7e7bd93 into master Nov 1, 2023
13 of 17 checks passed
@Maheshkale447 Maheshkale447 deleted the Feature/AutoUpdateBrowserDriver branch November 1, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants