Skip to content

Fix to warning on the logs when using Flutter 3.0.0 with the flutter_form_bloc #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix to warning on the logs when using Flutter 3.0.0 with the flutter_form_bloc #318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7428a19
fix: WidgetsBinding' which excludes null
babakoto Aug 16, 2022
67e2de5
fix: field bloc utils
babakoto Aug 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/flutter_form_bloc/lib/src/flutter_typeahead.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,7 +629,7 @@ class _TypeAheadFieldState<T> extends State<TypeAheadField<T>>
// this._suggestionsBox._overlayEntry?.remove();
// }
this._suggestionsBox!.widgetMounted = false;
WidgetsBinding.instance!.removeObserver(this);
WidgetsBinding.instance.removeObserver(this);

if (isWebMobile) {
_keyboardSubscription.cancel();
Expand All @@ -653,7 +653,7 @@ class _TypeAheadFieldState<T> extends State<TypeAheadField<T>>
@override
void initState() {
super.initState();
WidgetsBinding.instance!.addObserver(this);
WidgetsBinding.instance.addObserver(this);
_hideSuggestionsController = PublishSubject<void>();

if (widget.textFieldConfiguration.controller == null) {
Expand Down Expand Up @@ -689,7 +689,7 @@ class _TypeAheadFieldState<T> extends State<TypeAheadField<T>>
}
};

WidgetsBinding.instance!.addPostFrameCallback((duration) {
WidgetsBinding.instance.addPostFrameCallback((duration) {
if (mounted) {
this._initOverlayEntry();
// calculate initial suggestions list size
Expand Down Expand Up @@ -728,7 +728,7 @@ class _TypeAheadFieldState<T> extends State<TypeAheadField<T>>
/// TODO: Create Pull Request
/// Called for resize the suggestions box when have error
void _onChange() {
WidgetsBinding.instance!.addPostFrameCallback((duration) {
WidgetsBinding.instance.addPostFrameCallback((duration) {
_suggestionsBox!.resize();
});
}
Expand Down Expand Up @@ -982,7 +982,7 @@ class _SuggestionsListState<T> extends State<_SuggestionsList<T>>
widget.controller!.addListener(this._controllerListener);

_hideSuggestionsSubscription = widget.hideSuggestions.listen((_) {
WidgetsBinding.instance!.addPostFrameCallback((duration) {
WidgetsBinding.instance.addPostFrameCallback((duration) {
if (this.mounted) {
setState(() {
this
Expand Down
4 changes: 2 additions & 2 deletions packages/form_bloc/lib/src/blocs/field/field_bloc_utils.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class FieldBlocUtils {
final hasValidators = validators != null;

if (hasValidators) {
for (var validator in validators!) {
for (var validator in validators) {
error = validator(value);
if (error != null) return error;
}
Expand Down Expand Up @@ -52,7 +52,7 @@ class FieldBlocUtils {

var isValidating = !hasInitialStateError &&
hasAsyncValidators &&
asyncValidators!.isNotEmpty;
asyncValidators.isNotEmpty;

return isValidating;
}
Expand Down