Skip to content

Conversation

@dima-dencep
Copy link
Contributor

@Camotoy
Copy link
Member

Camotoy commented Nov 1, 2025

Hi! Thanks for the PR.

We gave this some discussion, and while we generally agree it's all right to expose, we think we'd rather have this as API instead. Is this something you'd be interested in?

@dima-dencep
Copy link
Contributor Author

Yes, but the GeyserSession itself is internal (since it is not in the API module), so

@Camotoy
Copy link
Member

Camotoy commented Nov 1, 2025

GeyserSession implements GeyserConnection, so we'd just need to add an API method there and an enum in API that maps to MCProtocolLib's enum.

@dima-dencep

This comment has been minimized.

@onebeastchris
Copy link
Member

I agree with camo - this should be proper API

@dima-dencep dima-dencep closed this Nov 5, 2025
@dima-dencep dima-dencep deleted the state branch November 5, 2025 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants