Skip to content

Conversation

@oryxel1
Copy link
Collaborator

@oryxel1 oryxel1 commented Sep 22, 2025

This is my second attempt, since I screw up the last one :) yay! so.

Changes:

  • Deleted grass path collision fix since as of 1.21.71, this block collision is the same as java edition.
  • Deleted the logic for stepping in correctPosition, since this caused many issues (already discuss in Discord).
  • Refactor code inside correctPosition, make it little bit more readable.
  • correctPosition now no longer return true/false, as in the original code this method always return true.
  • Now for collisions fixes like trapdoor/door/glass pane/iron bar. Properly calculate the distance we actually need to move player position by instead of just moving it by a certain value, as the player could actually just clip less than that value, causing the position get offset more than it needed to.
  • Fixed chest collision by moving player position down, resolve: Incorrect chest collision on bedrock #3277 and resolve Damage with flooded chests #4955
  • Fixed setback when hitting your head to an lantern
  • Fixed setback when moving into an scaffolding due to collision differences (can be shown in getting stuck #5787, however the player will fall through the scaffolding unlike java where they can work on it (bedrock behaviour)).
  • Also fixed some other small issues caused by my last PR.

* Revert last change, move everything to a different package, added end portal fix.

* Oops.

* Fixed lantern collision.

* Fixed conduit collision.

* Fixed scaffolding collision.

* Fixed bell collision and sea pickle collision.

* Avoid loop.

* oops.

* oops x2.

* Change comments.
@oryxel1 oryxel1 marked this pull request as draft September 22, 2025 15:01
* Revert last change, move everything to a different package, added end portal fix.

* Oops.

* Fixed lantern collision.

* Fixed conduit collision.

* Fixed scaffolding collision.

* Fixed bell collision and sea pickle collision.

* Avoid loop.

* oops.

* oops x2.

* Change comments.
@oryxel1 oryxel1 added PR: Needs Testing When a PR needs testing but is currently not under review PR: Bugfix When a PR contains a bugfix labels Sep 22, 2025
@onebeastchris
Copy link
Member

I wonder if the collision fix for trap doors fixes #2951?

Let me know once this is ready for review & I'll do testing on my end

@oryxel1
Copy link
Collaborator Author

oryxel1 commented Sep 29, 2025

I wonder if the collision fix for trap doors fixes #2951?

Nope it won't since as of now we're doing Don't correct position if controlling a vehicle, some changes have to made on the PR if we wanted to fix that.

Edit: Can't reproducible as of latest also.

@oryxel1 oryxel1 marked this pull request as ready for review September 30, 2025 11:59
@oryxel1 oryxel1 marked this pull request as draft September 30, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bugfix When a PR contains a bugfix PR: Needs Testing When a PR needs testing but is currently not under review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Damage with flooded chests Incorrect chest collision on bedrock

3 participants