Skip to content

Conversation

@oryxel1
Copy link
Collaborator

@oryxel1 oryxel1 commented Jul 10, 2025

Resolve: #5409 and also match Java behaviour now.

This works by overriding the vanilla fireworks rocket with a custom item that is basically the same, making player unable to boost client-sided until the server send a movement effect packet, which was already implemented in #5658.

  • Working custom fake fireworks item.
  • Translate the fireworks tag to lore so it's visible on the fake fireworks rocket.

Potential issues:

  • Will now only show english since everything are translated into lore (except the item name).
  • Some resource pack that messes around with fireworks rocket item might not works anymore, ofc this only applied to the fireworks item and not other thing that the resource pack have to offer.

Feel free to play around, test and comment on this as much as you'd like :D

@oryxel1 oryxel1 marked this pull request as ready for review July 11, 2025 04:06
@oryxel1
Copy link
Collaborator Author

oryxel1 commented Jul 11, 2025

This PR can now be review and merge.

@oryxel1
Copy link
Collaborator Author

oryxel1 commented Jul 11, 2025

Turn out you don't necessary need to register a custom item, you just need to make the original fireworks rocket item version data driven, I will be moving (and making changes) to this PR and move it to this PR: #5673

@oryxel1 oryxel1 closed this Jul 11, 2025
@oryxel1 oryxel1 deleted the custom-fireworks branch September 30, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cancelling PlayerElytraBoostEvent is ignored by bedrock players

1 participant