Handle ClientboundTickingStatePacket correctly and fix Throwable Scales #4850
+277
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Camotoy
reviewed
Jul 12, 2024
core/src/main/java/org/geysermc/geyser/session/GeyserSession.java
Outdated
Show resolved
Hide resolved
Konicai
requested changes
Jul 13, 2024
core/src/main/java/org/geysermc/geyser/entity/type/ThrowableItemEntity.java
Show resolved
Hide resolved
core/src/main/java/org/geysermc/geyser/session/GeyserSession.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/geysermc/geyser/session/GeyserSession.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/geysermc/geyser/session/GeyserSession.java
Outdated
Show resolved
Hide resolved
|
It would also be nice to implement ClientboundTickingStepPacket if you're able |
letsgoawaydev
force-pushed
the
tick-rate-handling
branch
2 times, most recently
from
47e69a1 to
83fab59
Compare
Fixed in latest commit. |
letsgoawaydev
changed the title
|
Can review in 12hrs |
Camotoy
reviewed
Jul 17, 2024
core/src/main/java/org/geysermc/geyser/entity/type/ThrowableItemEntity.java
Show resolved
Hide resolved
core/src/main/java/org/geysermc/geyser/entity/type/Tickable.java
Outdated
Show resolved
Hide resolved
rtm516
reviewed
Jul 17, 2024
core/src/main/java/org/geysermc/geyser/session/GeyserSession.java
Outdated
Show resolved
Hide resolved
Co-authored-by: rtm516 <[email protected]>
core/src/main/java/org/geysermc/geyser/session/GeyserSession.java
Outdated
Show resolved
Hide resolved
|
Okay, I've fixed title animations, attack indicator and some item cooldowns to be updated with tick rate. I'm not sure what other things require changes but it should be ready for testing if anyone can |
core/src/main/java/org/geysermc/geyser/session/GeyserSession.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/geysermc/geyser/session/GeyserSession.java
Outdated
Show resolved
Hide resolved
Co-authored-by: chris <[email protected]>
|
Should be functional again as I have merged this with master |
onebeastchris
requested changes
Dec 7, 2024
core/src/main/java/org/geysermc/geyser/session/GeyserSession.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/geysermc/geyser/entity/type/LivingEntity.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/geysermc/geyser/entity/type/ThrowableItemEntity.java
Outdated
Show resolved
Hide resolved
…y.java Co-authored-by: chris <[email protected]>
…emEntity.java Co-authored-by: chris <[email protected]>
|
will fix build error soon |
|
Everything should be completed now |
onebeastchris
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles custom tick rates sent from the ClientboundTickingStatePacket correctly. This freezes all tickable entitys and changes the geyser session tick() function update speed correctly.