Revert a change, ensure that gathering all components works and doesn…

…'t throw due to duplicate keys
GeyserMC · Dec 10, 2024 · 8779eab · 8779eab
1 parent 06a9b28
commit 8779eab
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/core/src/main/java/org/geysermc/geyser/entity/type/living/animal/tameable/WolfEntity.java b/core/src/main/java/org/geysermc/geyser/entity/type/living/animal/tameable/WolfEntity.java
@@ -128,11 +128,7 @@ protected Tag<Item> getFoodTag() {
     public void setBody(ItemStack stack) {
         super.setBody(stack);
         isCurseOfBinding = ItemUtils.hasEffect(session, stack, EnchantmentComponent.PREVENT_ARMOR_CHANGE);
-        if (stack != null && stack.getDataComponents() != null) {
-            repairableItems = stack.getDataComponents().get(DataComponentType.REPAIRABLE);
-        } else {
-            repairableItems = null;
-        }
+        repairableItems = GeyserItemStack.from(stack).getComponent(DataComponentType.REPAIRABLE);
     }
 
     @Override

diff --git a/core/src/main/java/org/geysermc/geyser/item/type/Item.java b/core/src/main/java/org/geysermc/geyser/item/type/Item.java
@@ -49,7 +49,6 @@
 import org.geysermc.geyser.translator.item.BedrockItemBuilder;
 import org.geysermc.geyser.translator.text.MessageTranslator;
 import org.geysermc.geyser.util.MinecraftKey;
-import org.geysermc.mcprotocollib.protocol.data.game.item.component.DataComponent;
 import org.geysermc.mcprotocollib.protocol.data.game.item.component.DataComponentType;
 import org.geysermc.mcprotocollib.protocol.data.game.item.component.DataComponents;
 import org.geysermc.mcprotocollib.protocol.data.game.item.component.DyedItemColor;
@@ -111,12 +110,9 @@ public DataComponents gatherComponents(DataComponents others) {
             return baseComponents;
         }
 
-        //noinspection UnstableApiUsage
-        var builder = ImmutableMap.<DataComponentType<?>, DataComponent<?, ?>>builderWithExpectedSize(
-            baseComponents.getDataComponents().size() + others.getDataComponents().size());
-        builder.putAll(baseComponents.getDataComponents());
-        builder.putAll(others.getDataComponents());
-        return new DataComponents(builder.build());
+        DataComponents components = baseComponents.clone();
+        components.getDataComponents().putAll(others.getDataComponents());
+        return new DataComponents(ImmutableMap.copyOf(components.getDataComponents()));
     }
 
     @Nullable