Skip to content

Remove unused code from Call Class #1762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PratimMallick merged 1 commit into from
Aug 5, 2026
Merged

Remove unused code from Call Class #1762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 0 additions & 42 deletions stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/Call.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import androidx.compose.runtime.Stable
import io.getstream.android.video.generated.models.AcceptCallResponse
import io.getstream.android.video.generated.models.BlockUserResponse
import io.getstream.android.video.generated.models.CallSettingsRequest
import io.getstream.android.video.generated.models.CallSettingsResponse
import io.getstream.android.video.generated.models.GetCallResponse
import io.getstream.android.video.generated.models.GetOrCreateCallResponse
import io.getstream.android.video.generated.models.GoLiveResponse
Expand Down Expand Up @@ -402,8 +401,6 @@ public class Call(
*/
var audioFilter: InputAudioFilter? = null

// val monitor = CallHealthMonitor(this, scope, onIceRecoveryFailed)

/**
* This returns the local microphone volume level. The audio volume is a linear
* value between 0 (no sound) and 1 (maximum volume). This is not a raw output -
Expand All @@ -425,11 +422,6 @@ public class Call(
*/
val statLatencyHistory: MutableStateFlow<List<Int>> get() = statsReporter.statLatencyHistory

/**
* Call has been left and the object is cleaned up and destroyed.
*/
internal val isDestroyed: Boolean get() = lifecycle.isDestroyed

internal var peerConnectionFactory: StreamPeerConnectionFactory
get() = media.peerConnectionFactory
set(value) {
Expand All @@ -447,15 +439,6 @@ public class Call(
callSessionId = { sessionId },
)

/**
* Checks if the audioBitrateProfile has changed since the factory was created,
* and recreates the factory if needed. This should only be called before joining.
*
* If the factory hasn't been created yet, it will be created with the current profile
* when first accessed, so no recreation is needed.
*/
internal fun ensureFactoryMatchesAudioProfile() = media.ensureFactoryMatchesAudioProfile()

internal val clientCapabilities = ConcurrentHashMap<String, ClientCapability>().apply {
put(
ClientCapability.CLIENT_CAPABILITY_SUBSCRIBER_VIDEO_PAUSE.name,
Expand Down Expand Up @@ -561,31 +544,6 @@ public class Call(
callJoinInterceptor,
)

internal fun isPermanentError(error: Any): Boolean = joinCoordinator.isPermanentError(error)

internal suspend fun _join(
create: Boolean = false,
createOptions: CreateCallOptions? = null,
ring: Boolean = false,
notify: Boolean = false,
hintHighScaleLivestreamPublisher: Boolean? = null,
joinAnalyticsModel: JoinAnalyticsModel,
): Result<RtcSession> = joinCoordinator.joinInternal(
create,
createOptions,
ring,
notify,
hintHighScaleLivestreamPublisher,
joinAnalyticsModel,
)

/** Resets the leave guard so a fresh join can run after a previous leave. */
internal fun resetLeaveGuard() = lifecycle.resetLeaveGuard()

/** Applies server-provided call settings to the local media manager. */
internal fun updateMediaManagerFromSettings(callSettings: CallSettingsResponse) =
media.updateMediaManagerFromSettings(callSettings)

internal suspend fun collectStats(): CallStatsReport = statsReporter.collectStats()

// region Reconnection — unified loop
Expand Down
4 changes: 4 additions & 0 deletions ...-core/src/main/kotlin/io/getstream/video/android/core/call/components/CallMediaManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,9 @@ internal class CallMediaManager(
/**
* Checks if the audioBitrateProfile has changed since the factory was created,
* and recreates the factory if needed. This should only be called before joining.
*
* If the factory hasn't been created yet, it will be created with the current profile
* when first accessed, so no recreation is needed.
*/
fun ensureFactoryMatchesAudioProfile() {
val factory = _peerConnectionFactory
Expand Down Expand Up @@ -173,6 +176,7 @@ internal class CallMediaManager(
// Next access to peerConnectionFactory will recreate it with current profile
}

/** Applies server-provided call settings to the local media manager. */
fun updateMediaManagerFromSettings(callSettings: CallSettingsResponse) {
val camera = mediaManager.camera
val microphone = mediaManager.microphone
Expand Down
Loading