Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decompose Call into focused internal components #1747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Decompose Call into focused internal components #1747
Changes from all commits
908041a16b0487713958c5a529c974dd01549ecb708ad52187537c76e156d7e1d4cdf82adf95e543439f60c12869c374eaFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Check warning on line 559 in stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/call/RtcSession.kt
Don't expose mutable flow types.
Check warning on line 560 in stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/call/RtcSession.kt
Don't expose mutable flow types.
Check failure on line 783 in stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/call/RtcSession.kt
Refactor this method to reduce its Cognitive Complexity from 17 to the 15 allowed.
Check warning on line 907 in stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/call/RtcSession.kt
Do not forget to remove this deprecated code someday.
Check warning on line 1602 in stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/call/RtcSession.kt
Merge this "if" statement with the nested one.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.