Skip to content

Conversation

@renefloor
Copy link
Collaborator

Submit a pull request

Closes FLU-315

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

Many events have impact on multiple state classes. This PR shares the type of events that are relevant for multiple state classes, so we are sure they are all handled the same.

@renefloor renefloor force-pushed the feature/improve-feed-event-handling branch from 5752e65 to 63a4173 Compare November 5, 2025 09:47
@renefloor renefloor force-pushed the feature/improve-feed-event-handling branch from 63a4173 to 7fc1798 Compare November 5, 2025 09:48
@renefloor renefloor changed the title merge feed and activity event handlers chore(llc): merge feed and activity event handlers Nov 5, 2025
@renefloor renefloor changed the title chore(llc): merge feed and activity event handlers feat(llc): merge feed and activity event handlers Nov 5, 2025
@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

❌ Patch coverage is 89.38907% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.03%. Comparing base (11b075c) to head (caf6550).

Files with missing lines Patch % Lines
...rc/state/event/partial_activity_event_handler.dart 84.44% 7 Missing ⚠️
...ages/stream_feeds/lib/src/models/comment_data.dart 84.37% 5 Missing ⚠️
...ackages/stream_feeds/lib/src/models/poll_data.dart 78.26% 5 Missing ⚠️
...ackages/stream_feeds/lib/src/state/feed_state.dart 91.66% 5 Missing ⚠️
...stream_feeds/lib/src/state/comment_list_state.dart 75.00% 4 Missing ⚠️
...ate/event/partial_activity_list_event_handler.dart 91.83% 4 Missing ⚠️
..._feeds/lib/src/state/event/feed_event_handler.dart 83.33% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   40.86%   48.03%   +7.17%     
==========================================
  Files         120      122       +2     
  Lines        3617     3818     +201     
==========================================
+ Hits         1478     1834     +356     
+ Misses       2139     1984     -155     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@renefloor renefloor force-pushed the feature/improve-feed-event-handling branch from 07854e7 to e78df58 Compare November 5, 2025 13:56
@renefloor renefloor marked this pull request as ready for review November 7, 2025 12:50
@renefloor renefloor requested a review from a team as a code owner November 7, 2025 12:50
@renefloor renefloor force-pushed the feature/improve-feed-event-handling branch from 654ae2e to caf6550 Compare November 7, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants