-
Notifications
You must be signed in to change notification settings - Fork 0
feat(llc): merge feed and activity event handlers #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
renefloor
wants to merge
9
commits into
main
Choose a base branch
from
feature/improve-feed-event-handling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5752e65 to
63a4173
Compare
63a4173 to
7fc1798
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
==========================================
+ Coverage 40.86% 48.03% +7.17%
==========================================
Files 120 122 +2
Lines 3617 3818 +201
==========================================
+ Hits 1478 1834 +356
+ Misses 2139 1984 -155 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
07854e7 to
e78df58
Compare
654ae2e to
caf6550
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submit a pull request
Closes FLU-315
CLA
Description of the pull request
Many events have impact on multiple state classes. This PR shares the type of events that are relevant for multiple state classes, so we are sure they are all handled the same.