Allow alternatives to pk for object lookup #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry. tests. working on it. |
|
Note: works for Django 2.0+ / Python 3.5+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi you all. First - thanks for providing the django client project.
Some Django projects use both an integer id/pk along with a separate uuid field where only the uuid is exposed externally to clients. This PR adds DRF-like field lookup name functionality so a user could choose to have activities use that identifier rather than pk.
Note that this is a separate problem than the UUID issue here: https://github.com/GetStream/stream-django/pull/55/files
I'm using this on a personal project but providing in case you want to consider (or point others to a solution in case it comes up in the future).