Skip to content

[CI] Improve linters and git hooks #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

testableapple
Copy link
Contributor

@testableapple testableapple commented Jul 10, 2025

Resolve https://linear.app/stream/issue/IOS-321

🎯 Goal

We introduced a new approach to git hooks on Feeds and fixed linters' issues. The goal of this PR is to align this across all iOS repos.

πŸ„β€β™‚οΈ Local support

To update git hooks locally, run:

bundle install
bundle exec lefthook install

If you use Git GUI (e.g.: Fork), you have to let the GUI know about zsh PATH explicitly:
Screenshot 2025-07-10 at 5 16 15β€―PM

Summary by CodeRabbit

  • Chores

    • Switched to Lefthook for managing Git hooks and automated code formatting in pre-commit.
    • Updated workflow automation to use Fastlane for Swift code formatting and linting.
    • Added Lefthook gem and configuration.
    • Removed custom scripts and manual Git hook setup in favor of Lefthook.
    • Removed SwiftLint build phases from the Xcode project.
  • Style

    • Improved code formatting and whitespace in several files.
    • Added and adjusted SwiftLint directives for specific functions to manage linting rules.
  • Documentation

    • No user-facing documentation changes.

@testableapple testableapple requested a review from a team as a code owner July 10, 2025 13:25
@testableapple testableapple added the πŸ€– CI/CD Any work related to CI/CD label Jul 10, 2025
Copy link

github-actions bot commented Jul 10, 2025

1 Warning
⚠️ Big PR
1 Message
πŸ“– There seems to be app changes but CHANGELOG wasn't modified.
Please include an entry if the PR includes user-facing changes.
You can find it at CHANGELOG.md.

Generated by 🚫 Danger

@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Jul 10, 2025

SDK Size

title develop branch diff status
StreamChatSwiftUI 9.12 MB 9.12 MB 0 KB 🟒

@testableapple testableapple force-pushed the ci/improve-linters-and-git-hooks branch 6 times, most recently from b972a7d to 6e645f3 Compare July 11, 2025 15:15
@testableapple testableapple force-pushed the ci/improve-linters-and-git-hooks branch from 6e645f3 to 03a73db Compare July 11, 2025 16:07
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
55.9% Coverage on New Code (required β‰₯ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ€– CI/CD Any work related to CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants