Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add centralized dialog management #2489

Merged
merged 33 commits into from
Sep 16, 2024

refactor: unmound popper element if closed in useDialogAnchor

9d1ee9d
Select commit
Loading
Failed to load commit list.
Merged

feat: add centralized dialog management #2489

refactor: unmound popper element if closed in useDialogAnchor
9d1ee9d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Sep 9, 2024 in 1s

93.94% of diff hit (target 10.00%)

View this Pull Request on Codecov

93.94% of diff hit (target 10.00%)

Annotations

Check warning on line 58 in src/components/Dialog/DialogsManager.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/components/Dialog/DialogsManager.ts#L58 

Added line #L58 was not covered by tests

Check warning on line 61 in src/components/Dialog/DialogsManager.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/components/Dialog/DialogsManager.ts#L61 

Added line #L61 was not covered by tests

Check warning on line 64 in src/components/Dialog/DialogsManager.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/components/Dialog/DialogsManager.ts#L64 

Added line #L64 was not covered by tests

Check warning on line 108 in src/components/Dialog/DialogsManager.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/components/Dialog/DialogsManager.ts#L108 

Added line #L108 was not covered by tests

Check warning on line 318 in src/components/Message/utils.tsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/components/Message/utils.tsx#L318 

Added line #L318 was not covered by tests

Check warning on line 128 in src/components/Reactions/ReactionSelector.tsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/components/Reactions/ReactionSelector.tsx#L128 

Added line #L128 was not covered by tests
View more details on Codecov