Skip to content

fix: image tap functionality on android #3272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 30, 2025
Merged

fix: image tap functionality on android #3272

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bcaed85
Fix image tap issue on android devices
sharanya08p Oct 29, 2025
0e52ecf
revert changes
sharanya08p Oct 29, 2025
73de918
Fix image tap issue by adding min distance threshold
sharanya08p Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions package/src/components/Message/MessageSimple/MessageBubble.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ export const SwipableMessageBubble = React.memo(
);

const SWIPABLE_THRESHOLD = 25;
const MINIMUM_DISTANCE = 8;

const triggerHaptic = NativeHandlers.triggerHaptic;

Expand All @@ -120,14 +121,17 @@ export const SwipableMessageBubble = React.memo(
const xDiff = Math.abs(event.changedTouches[0].x - touchStart.value.x);
const yDiff = Math.abs(event.changedTouches[0].y - touchStart.value.y);
const isHorizontalPanning = xDiff > yDiff;
const hasMinimumDistance = xDiff > MINIMUM_DISTANCE || yDiff > MINIMUM_DISTANCE;

if (isHorizontalPanning) {
// Only activate if there's significant horizontal movement
if (isHorizontalPanning && hasMinimumDistance) {
state.activate();
isSwiping.value = true;
if (!shouldRenderSwipeableWrapper) {
runOnJS(setShouldRenderAnimatedWrapper)(isSwiping.value);
}
} else {
} else if (hasMinimumDistance) {
// If there's significant movement but not horizontal, fail the gesture
state.fail();
}
})
Expand Down
Loading