-
Notifications
You must be signed in to change notification settings - Fork 384
feat(ui): add configurable StreamBackButton unread count
#2816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
VelikovPetar
merged 12 commits into
master
from
feature/FLU-557_fix_back_button_unread_counts
Jul 30, 2026
+752
−19
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a1f86e7
feat(ui): add configurable StreamBackButton unread count
VelikovPetar ea50a4c
Merge branch 'master' into feature/FLU-557_fix_back_button_unread_counts
VelikovPetar 4f3aa78
refactor(ui): accept a Widget unreadIndicator on StreamBackButton
VelikovPetar fe2ba03
chore: Update Goldens
VelikovPetar afaafde
test(ui): assert StreamBackButton shows no badge at zero unread count
VelikovPetar a72d099
Merge branch 'master' into feature/FLU-557_fix_back_button_unread_counts
VelikovPetar 498ee03
Fix PR remarks.
VelikovPetar 2d128eb
Merge branch 'master' into feature/FLU-557_fix_back_button_unread_counts
VelikovPetar 75d4ca4
Address PR remarks
VelikovPetar 2665d84
Fix formatting
VelikovPetar 9c123ce
Merge branch 'master' into feature/FLU-557_fix_back_button_unread_counts
xsahil03x 34ad1af
Merge branch 'master' into feature/FLU-557_fix_back_button_unread_counts
VelikovPetar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+1.29 KB
...am_chat_flutter/test/src/indicators/goldens/ci/stream_unread_indicator_dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.12 KB
...m_chat_flutter/test/src/indicators/goldens/ci/stream_unread_indicator_light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.04 KB
...utter/test/src/indicators/goldens/ci/stream_unread_indicator_overflow_light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can support
excludeCidhere too. wdyt?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In theory yes, should be feasible. I decided to not do it now because it wasn't part of the initial bug report. However I have one concern: In that case, we could in theory pass both
cidandexcludeCidto the_UnreadChannelsconfig -> This can become a bit confusing, but if we prioritize the setup in the following way:cid != null-> show that specific channel unread countexcludeCid != null-> all unread channels - 1 (if excluded channel has unread)(Ideally we would have different factory methods for
channelsvscurrentChannel, but currently thechannelsfactory handles both cases, so I think introducing new API might be confusing).What do you think about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets skip it until we have a usecase