Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(repo): bump min flutter version to 3.24.5 #2068

Open
wants to merge 44 commits into
base: master
Choose a base branch
from

Conversation

xsahil03x
Copy link
Member

@xsahil03x xsahil03x commented Dec 19, 2024

This pull request includes several significant changes to improve the workflows, update dependencies, and enhance the codebase. The most important changes include the introduction of a new Pana workflow, updates to Flutter and Dart versions, and various dependency management improvements.

Workflow Improvements:

  • Added a new Pana workflow in .github/actions/pana/action.yml to verify the Pana score, including steps for installing Flutter and Pana, and verifying the score.
  • Updated .github/workflows/pana.yml to use the new Pana action for verifying Pana scores across multiple packages.

Dependency Management:

  • Introduced a patch file .github/actions/pana/chore__temporarily_override_dep_to_local.patch to temporarily override dependencies to local paths for testing purposes.
  • Updated melos.yaml to include environment configurations and dependency versions, ensuring consistent dependency management across the project. [1] [2]

Version Updates:

  • Updated Flutter version to 3.24.5 in multiple workflow files to ensure compatibility with the latest stable release. [1] [2]
  • Updated minimum Dart version to 3.5.4 and minimum Flutter version to 3.24.5 in various pubspec.yaml and CHANGELOG.md files to reflect the latest requirements. [1] [2] [3] [4] [5]

Code Enhancements:

  • Modified UserBlockResponse class in packages/stream_chat/lib/src/core/api/responses.dart to prevent JSON serialization for toJson method, improving performance.
  • Improved readability and maintainability of the _IsSameMessageAs matcher in packages/stream_chat/test/src/matchers.dart.

deven98
deven98 previously approved these changes Dec 19, 2024
Copy link
Contributor

@deven98 deven98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 15.38462% with 11 lines in your changes missing coverage. Please review.

Project coverage is 61.03%. Comparing base (c8dce6e) to head (ef33169).

Files with missing lines Patch % Lines
...e_positioned_list/src/item_positions_listener.dart 0.00% 5 Missing ⚠️
.../channel_scroll_view/stream_channel_list_tile.dart 0.00% 4 Missing ⚠️
...ib/src/poll/poll_option_reorderable_list_view.dart 0.00% 1 Missing ⚠️
...ream_chat_flutter_core/lib/src/stream_channel.dart 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2068      +/-   ##
==========================================
- Coverage   61.04%   61.03%   -0.01%     
==========================================
  Files         336      336              
  Lines       20152    20152              
==========================================
- Hits        12301    12299       -2     
- Misses       7851     7853       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xsahil03x xsahil03x requested a review from deven98 December 20, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants