Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): add showFailedIndicator parameter into StreamMessageWidget #1976

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TinhHuynh
Copy link

@TinhHuynh TinhHuynh commented Jul 3, 2024

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

This PR added showFailedIndicator parameter into StreamMessageWidget to toggle displaying the failed message icon.

@TinhHuynh TinhHuynh changed the title feat: add showFailedIndicator parameter into StreamMessageWidget feat(ui): add showFailedIndicator parameter into StreamMessageWidget Jul 3, 2024
@TinhHuynh TinhHuynh force-pushed the feat/show-fail-indicator branch 4 times, most recently from 941142c to 97ad4c5 Compare July 3, 2024 16:11
@github-actions github-actions bot added the Stale label Jul 30, 2024
@cogivn cogivn force-pushed the feat/show-fail-indicator branch from fe84adf to 2a25a34 Compare July 31, 2024 02:10
@github-actions github-actions bot removed the Stale label Jul 31, 2024
@github-actions github-actions bot added the Stale label Sep 1, 2024
@cogivn cogivn force-pushed the feat/show-fail-indicator branch from 8f6de9a to 794614d Compare September 11, 2024 02:57
@github-actions github-actions bot removed the Stale label Sep 11, 2024
@cogivn cogivn force-pushed the feat/show-fail-indicator branch from 794614d to aeccb80 Compare September 20, 2024 03:37
@github-actions github-actions bot added Stale and removed Stale labels Oct 10, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.20%. Comparing base (91c42a9) to head (b582b65).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...flutter/lib/src/message_widget/message_widget.dart 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1976   +/-   ##
=======================================
  Coverage   60.20%   60.20%           
=======================================
  Files         317      317           
  Lines       18511    18515    +4     
=======================================
+ Hits        11144    11147    +3     
- Misses       7367     7368    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added Stale and removed Stale labels Nov 7, 2024
@cogivn cogivn force-pushed the feat/show-fail-indicator branch from b582b65 to 81f48c4 Compare November 12, 2024 03:30
@cogivn cogivn force-pushed the feat/show-fail-indicator branch from 81f48c4 to 7e314f8 Compare November 21, 2024 08:43
@github-actions github-actions bot added the Stale label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant