Skip to content

Commit

Permalink
Merge pull request #294 from GetStream/feature/pana
Browse files Browse the repository at this point in the history
add pana check gh action
  • Loading branch information
imtoori authored Mar 2, 2021
2 parents 3d43c84 + 807d978 commit 3332a48
Show file tree
Hide file tree
Showing 12 changed files with 154 additions and 46 deletions.
102 changes: 102 additions & 0 deletions .github/workflows/pana.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,102 @@
name: pana

env:
ACTIONS_ALLOW_UNSECURE_COMMANDS: 'true'

on:
pull_request:
branches:
- master
paths-ignore:
- 'docs/**'
push:
branches:
- master
paths-ignore:
- 'docs/**'

jobs:
stream_chat:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: axel-op/dart-package-analyzer@v3
id: analysis
with:
githubToken: ${{ secrets.GITHUB_TOKEN }}
relativePath: packages/stream_chat
- name: Check scores
env:
# NB: "analysis" is the id set above. Replace it with the one you used if different.
TOTAL: ${{ steps.analysis.outputs.total }}
TOTAL_MAX: ${{ steps.analysis.outputs.total_max }}
run: |
PERCENTAGE=$(( $TOTAL * 100 / $TOTAL_MAX ))
if (( $PERCENTAGE < 100 ))
then
echo Score too low!
exit 1
fi
stream_chat_persistence:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: axel-op/dart-package-analyzer@v3
id: analysis
with:
githubToken: ${{ secrets.GITHUB_TOKEN }}
relativePath: packages/stream_chat_persistence
- name: Check scores
env:
# NB: "analysis" is the id set above. Replace it with the one you used if different.
TOTAL: ${{ steps.analysis.outputs.total }}
TOTAL_MAX: ${{ steps.analysis.outputs.total_max }}
run: |
PERCENTAGE=$(( $TOTAL * 100 / $TOTAL_MAX ))
if (( $PERCENTAGE < 90 ))
then
echo Score too low!
exit 1
fi
stream_chat_flutter_core:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: axel-op/dart-package-analyzer@v3
id: analysis
with:
githubToken: ${{ secrets.GITHUB_TOKEN }}
relativePath: packages/stream_chat_flutter_core
- name: Check scores
env:
# NB: "analysis" is the id set above. Replace it with the one you used if different.
TOTAL: ${{ steps.analysis.outputs.total }}
TOTAL_MAX: ${{ steps.analysis.outputs.total_max }}
run: |
PERCENTAGE=$(( $TOTAL * 100 / $TOTAL_MAX ))
if (( $PERCENTAGE < 100 ))
then
echo Score too low!
exit 1
fi
stream_chat_flutter:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: axel-op/dart-package-analyzer@v3
id: analysis
with:
githubToken: ${{ secrets.GITHUB_TOKEN }}
relativePath: packages/stream_chat_flutter
- name: Check scores
env:
# NB: "analysis" is the id set above. Replace it with the one you used if different.
TOTAL: ${{ steps.analysis.outputs.total }}
TOTAL_MAX: ${{ steps.analysis.outputs.total_max }}
run: |
PERCENTAGE=$(( $TOTAL * 100 / $TOTAL_MAX ))
if (( $PERCENTAGE < 90 ))
then
echo Score too low!
exit 1
fi
8 changes: 4 additions & 4 deletions .github/workflows/stream_flutter_workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
timeout-minutes: 15
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- uses: actions/checkout@v2
with:
fetch-depth: 0
- name: 'Install Flutter'
Expand All @@ -40,7 +40,7 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 15
steps:
- uses: actions/checkout@v1
- uses: actions/checkout@v2
with:
fetch-depth: 0
- name: 'Install Flutter'
Expand Down Expand Up @@ -73,7 +73,7 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
- uses: actions/checkout@v1
- uses: actions/checkout@v2
with:
fetch-depth: 0
- name: 'Install Flutter'
Expand All @@ -89,7 +89,7 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 15
steps:
- uses: actions/checkout@v1
- uses: actions/checkout@v2
with:
fetch-depth: 0
- name: 'Install Flutter'
Expand Down
2 changes: 1 addition & 1 deletion packages/stream_chat/lib/version.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ import 'package:stream_chat/src/client.dart';

/// Current package version
/// Used in [StreamChatClient] to build the `x-stream-client` header
const PACKAGE_VERSION = '1.3.2-beta';
const PACKAGE_VERSION = '1.3.2+1-beta';
Original file line number Diff line number Diff line change
Expand Up @@ -202,24 +202,26 @@ class GiphyAttachment extends AttachmentWidget {
crossAxisAlignment: CrossAxisAlignment.center,
children: [
Expanded(
child: FlatButton(
child: Container(
height: 50,
onPressed: () {
streamChannel.channel.sendAction(message, {
'image_action': 'cancel',
});
},
child: Text(
'Cancel',
style: StreamChatTheme.of(context)
.textTheme
.bodyBold
.copyWith(
color: StreamChatTheme.of(context)
.colorTheme
.black
.withOpacity(0.5),
),
child: TextButton(
onPressed: () {
streamChannel.channel.sendAction(message, {
'image_action': 'cancel',
});
},
child: Text(
'Cancel',
style: StreamChatTheme.of(context)
.textTheme
.bodyBold
.copyWith(
color: StreamChatTheme.of(context)
.colorTheme
.black
.withOpacity(0.5),
),
),
),
),
),
Expand All @@ -232,20 +234,22 @@ class GiphyAttachment extends AttachmentWidget {
height: 50.0,
),
Expanded(
child: FlatButton(
child: Container(
height: 50,
onPressed: () {
streamChannel.channel.sendAction(message, {
'image_action': 'send',
});
},
child: Text(
'Send',
style: TextStyle(
color: StreamChatTheme.of(context)
.colorTheme
.accentBlue,
fontWeight: FontWeight.bold),
child: TextButton(
onPressed: () {
streamChannel.channel.sendAction(message, {
'image_action': 'send',
});
},
child: Text(
'Send',
style: TextStyle(
color: StreamChatTheme.of(context)
.colorTheme
.accentBlue,
fontWeight: FontWeight.bold),
),
),
),
),
Expand Down
4 changes: 2 additions & 2 deletions packages/stream_chat_flutter/lib/src/channel_list_view.dart
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ class _ChannelListViewState extends State<ChannelListView> {
left: 0,
bottom: 32,
child: Center(
child: FlatButton(
child: TextButton(
onPressed: widget.onStartChatPressed,
child: Text(
'Start a chat',
Expand Down Expand Up @@ -445,7 +445,7 @@ class _ChannelListViewState extends State<ChannelListView> {
),
style: Theme.of(context).textTheme.headline6,
),
FlatButton(
TextButton(
onPressed: () => _channelListController.loadData(),
child: Text('Retry'),
),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ class _MessageActionsModalState extends State<MessageActionsModal> {
Row(
mainAxisAlignment: MainAxisAlignment.center,
children: [
FlatButton(
TextButton(
child: Text(
'OK',
style: StreamChatTheme.of(context)
Expand Down Expand Up @@ -413,7 +413,7 @@ class _MessageActionsModalState extends State<MessageActionsModal> {
Row(
mainAxisAlignment: MainAxisAlignment.center,
children: [
FlatButton(
TextButton(
child: Text(
'OK',
style: StreamChatTheme.of(context)
Expand Down
2 changes: 1 addition & 1 deletion packages/stream_chat_flutter/lib/src/message_input.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2139,7 +2139,7 @@ class MessageInputState extends State<MessageInput> {
Row(
mainAxisAlignment: MainAxisAlignment.center,
children: [
FlatButton(
TextButton(
child: Text(
'OK',
style: StreamChatTheme.of(context)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ class _MessageSearchListViewState extends State<MessageSearchListView> {
padding: const EdgeInsets.only(top: 16.0),
child: Text(message),
),
RaisedButton(
ElevatedButton(
onPressed: () {
_messageSearchListController.loadData();
},
Expand Down
2 changes: 1 addition & 1 deletion packages/stream_chat_flutter/lib/src/user_list_view.dart
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ class _UserListViewState extends State<UserListView>
),
child: Text(message),
),
FlatButton(
TextButton(
onPressed: () {
_userListController.loadData();
},
Expand Down
6 changes: 3 additions & 3 deletions packages/stream_chat_flutter/lib/src/utils.dart
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ Future<bool> showConfirmationDialog(
Row(
mainAxisAlignment: MainAxisAlignment.spaceBetween,
children: [
FlatButton(
TextButton(
child: Text(
cancelText,
style: StreamChatTheme.of(context)
Expand All @@ -75,7 +75,7 @@ Future<bool> showConfirmationDialog(
Navigator.of(context).pop(false);
},
),
FlatButton(
TextButton(
child: Text(
okText,
style: StreamChatTheme.of(context)
Expand Down Expand Up @@ -145,7 +145,7 @@ Future<bool> showInfoDialog(
Row(
mainAxisAlignment: MainAxisAlignment.spaceBetween,
children: [
FlatButton(
TextButton(
child: Text(
okText,
style: TextStyle(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ class ChannelQueryDao extends DatabaseAccessor<MoorChatDatabase>
?.where((s) => possibleSortingFields.contains(s.field))
?.toList(growable: false);

Comparator<ChannelModel> chainedComparator = (a, b) {
var chainedComparator = (ChannelModel a, ChannelModel b) {
final dateA = a.lastMessageAt ?? a.createdAt;
final dateB = b.lastMessageAt ?? b.createdAt;
return dateB.compareTo(dateA);
Expand Down
2 changes: 2 additions & 0 deletions packages/stream_chat_persistence/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ environment:
sdk: ">=2.7.0 <3.0.0"

dependencies:
flutter:
sdk: flutter
moor: ^3.4.0
path: ^1.7.0
path_provider: ^1.6.27
Expand Down

0 comments on commit 3332a48

Please sign in to comment.