The post_review_comment response checking assumes (as per comment) that some updated review information should be returned.
This is not the case - see docs https://gerrit-documentation.storage.googleapis.com/Documentation/3.13.3/rest-api-changes.html#set-review
Only changed labels or added reviewers are returned - if no change like that happened, the return might be empty (the comment is still being added).
Not related to this PR but I would greatly appreciate a post_draft_comment (harder to implement as we would probably need to "start a review" and then add draft comments to it).
My reasoning: I'm trying to make an agentic code review, but I would like to have all comments posted as drafts for the human to review them before spamming the original author.
The
post_review_commentresponse checking assumes (as per comment) that some updated review information should be returned.This is not the case - see docs https://gerrit-documentation.storage.googleapis.com/Documentation/3.13.3/rest-api-changes.html#set-review
Only changed labels or added reviewers are returned - if no change like that happened, the return might be empty (the comment is still being added).
Not related to this PR but I would greatly appreciate a
post_draft_comment(harder to implement as we would probably need to "start a review" and then add draft comments to it).My reasoning: I'm trying to make an agentic code review, but I would like to have all comments posted as drafts for the human to review them before spamming the original author.