-
Notifications
You must be signed in to change notification settings - Fork 134
Fmc notebook #1369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Fmc notebook #1369
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Looks great @biancafichera! I've made some minor revisions and some suggestions below.
|
Oh sorry I see that the other dataset notebooks are using the "alert" blocks now. I still don't like them but looks like that's the standard so you should revert it back |
Yeah, we rolled them out across the product notebooks a few months ago - they render OK in Jupyter Lab and Knowledge Hub so those are the most important places I think: |
View / edit / reply to this conversation on ReviewNB robbibt commented on 2025-08-13T02:52:45Z I think right now the convention for the "Products used:" section is to use the datacube product IDs (e.g. biancafichera commented on 2025-08-13T04:31:59Z You're right! I had accidentally used the DEA Coastlines notebook as a reference, but that doesn't use a derivative raster product - I'll change this now. |
View / edit / reply to this conversation on ReviewNB robbibt commented on 2025-08-13T02:52:45Z Line #11. from matplotlib.colors import LinearSegmentedColormap Can we move this line up next to the other matplotlib import above it? Everything under biancafichera commented on 2025-08-13T04:32:58Z Great pickup, I'll change that now |
View / edit / reply to this conversation on ReviewNB robbibt commented on 2025-08-13T02:52:46Z Line #4. dc_products.loc[['ga_s2am_fmc', 'ga_s2bm_fmc', 'ga_s2cm_fmc']] I've sent a Teams message about the naming conventions here - right now they don't quite match the formal DEA product ID conventions which require a "_3" suffix to signify the collection the data came from: https://knowledge.dea.ga.gov.au/guides/reference/collection_3_naming/#landsat-fractional-cover-odc-product biancafichera commented on 2025-08-13T04:36:05Z I have updated the notebook in a separate branch with the updated product names (added "_3") - for now, I won't change the product name in this branch so the notebook can still run without error until the new product name has been indexed. |
View / edit / reply to this conversation on ReviewNB robbibt commented on 2025-08-13T02:52:47Z Line #1. # Define colour map for plotting I also agree with @cbur24 here - linear sequential data really should use a linear (ideally perceptually uniform) colour scheme, not a diverging one like this. I'd recommend checking out the "viridis", "cmocean" or "colorbrewer" family of schemes to see if there's a nice one there! biancafichera commented on 2025-08-13T04:37:58Z We do agree, but we have been instructed to keep the symbology the same as what was used previously in the Australian flammability monitoring system interactive map and this is what they used! Possibly in future we could change it GL-S commented on 2025-08-20T06:03:13Z there are several studies in the literature that explore critical thresholds of FMC in relation to flammability. It is possible the colours were originally assigned in function of some of these thresholds. Although they would be different for different vegetation types, while the product shows an "overall FMC", so a linear colour scheme would make sense Kooie-cate commented on 2025-09-02T01:54:07Z We appreciate everyone's input on the colour scale and while we know it is not ideal we are retaining this blue-yellow-red diverging colour sceme to maintain the look and feel of the original AFMS (MODIS based FMC). This decision has been made to assist with the transition of existing users who are familiar with AFMS; as the product is moving platforms and changing resolution we don't want it to be completely different. |
This is a fantastic notebook @biancafichera, amazing work! I left a few minor comments via ReviewNB - the main one I guess is the product ID naming convention, which might be tricky to fix (but worth it for consistency with the rest of our products). |
You're right! I had accidentally used the DEA Coastlines notebook as a reference, but that doesn't use a derivative raster product - I'll change this now. View entire conversation on ReviewNB |
Great pickup, I'll change that now View entire conversation on ReviewNB |
I have updated the notebook in a separate branch with the updated product names (added "_3") - for now, I won't change the product name in this branch so the notebook can still run without error until the new product name has been indexed. View entire conversation on ReviewNB |
We do agree, but we have been instructed to keep the symbology the same as what was used previously in the Australian flammability monitoring system interactive map and this is what they used! Possibly in future we could change it View entire conversation on ReviewNB |
there are several studies in the literature that explore critical thresholds of FMC in relation to flammability. It is possible the colours were originally assigned in function of some of these thresholds. Although they would be different for different vegetation types, while the product shows an "overall FMC", so a linear colour scheme would make sense View entire conversation on ReviewNB |
We appreciate everyone's input on the colour scale and while we know it is not ideal we are retaining this blue-yellow-red diverging colour sceme to maintain the look and feel of the original AFMS (MODIS based FMC). This decision has been made to assist with the transition of existing users who are familiar with AFMS; as the product is moving platforms and changing resolution we don't want it to be completely different. View entire conversation on ReviewNB |
Proposed changes
This is the first Introduction to DEA Fuel Moisture Content notebook to be put onto the knowledge hub for our launch of the new product later in August. Note: Links to DEA Maps, Knowledge Hub, DEA Explorer haven't been updated since they are not live yet.
Checklist
If this is a notebook, then have you:
Load packages
General advice
)jupyterlab_code_formatter
tool can be used to format code cells to a consistent style: select each code cell, then clickEdit
and then one of theApply X Formatter
options (YAPF
orBlack
are recommended).Notebook currently compatible with
line below the notebook title to reflect the environments the notebook is compatible with