Feat/javascript to python #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eideegeo
force-pushed
the
feat/javascript-to-python
branch
from
751c191 to
aab620b
Compare
eideegeo
force-pushed
the
feat/javascript-to-python
branch
from
aab620b to
ff59ca6
Compare
The client factory was embedded in server main source. However, it was not used by it, and it import some heavyweight dependencies (graalvm js engine, jython). As it serves for test purposes, we put it in project test fixtures, so we can use it in tests, and we will be able to use it in future dependant test modules.
Disable it on pull requests, as it fails when doing a pull request from a fork.
|
Obsolete, we directly merged into pdssp repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.