Fix/fast json schema #156
Merged
Fix/fast json schema #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to work on new methods ?
test cases in test_routes.py expect a validation error format thats need to be match fastjsonschema provides
{key} is a required property for missing required fields
Additionnal properties are not allowed for extra properties
Modifications :
- Catch fastjsonjsonschema exceptions and extract the field name
- transform the error message to match the format expected by tests
- uses string manipulations to handle both mising required fields and additionnal properties cases
pytest : 40/40 passed
BotellaA
reviewed
Jul 17, 2025
JulienChampagnol
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.