feat(client): add configurable timeout support for all API operations #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add configurable timeouts for single, batch, and list API operations - Default timeouts: 5s (single), 30min (batch), 60s (list API) - Users can override defaults via GeocodioClient constructor - Pass appropriate timeout from each method to _request()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds configurable timeout support for all Geocodio API operations, addressing timeout issues encountered in production environments where operations may take longer than the previously hard-coded 30-second timeout.
Changes
GeocodioClient:single_timeout: For single geocoding/reverse geocoding operations (default: 5 seconds)batch_timeout: For batch geocoding operations (default: 30 minutes)list_timeout: For List API operations (default: 60 seconds)_request()method to accept an optional timeout parameterTest Plan
single_timeoutbatch_timeoutlist_timeoutTest Coverage
tests/unit/test_client.pytests/e2e/test_lists_api.py(previously failing due to timeout, now passing)