Skip to content

[Fixes #14111] Fix Harvester lookup failure caused by trailing ? during the remote resource upload through the API#14112

Merged
mattiagiupponi merged 6 commits intomasterfrom
ISSUE_14111
Apr 10, 2026
Merged

[Fixes #14111] Fix Harvester lookup failure caused by trailing ? during the remote resource upload through the API#14112
mattiagiupponi merged 6 commits intomasterfrom
ISSUE_14111

Conversation

@Gpetrak
Copy link
Copy Markdown
Member

@Gpetrak Gpetrak commented Apr 7, 2026

This PR was created according to this issue: #14111

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@Gpetrak Gpetrak added this to the 5.1.0 milestone Apr 7, 2026
@Gpetrak Gpetrak requested a review from mattiagiupponi April 7, 2026 09:18
@Gpetrak Gpetrak added the bug label Apr 7, 2026
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Apr 7, 2026
@mattiagiupponi mattiagiupponi requested a review from sijandh35 April 7, 2026 09:19
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the WMS remote handler to correctly format the OWS URL by conditionally adding the query string, preventing trailing question marks when no query parameters are present. The feedback suggests using urllib.parse methods for a more robust and idiomatic approach to URL manipulation.

@Gpetrak Gpetrak marked this pull request as ready for review April 7, 2026 10:48
@giohappy
Copy link
Copy Markdown
Contributor

giohappy commented Apr 7, 2026

@Gpetrak I suspect this won't cover the cases where the URL includes parameters.
As an example this WMS service requires the custom map parameter to work. the https://www502.regione.toscana.it/ows_ofc/com.rt.wms.RTmap/wms?map=owsofc&

@Gpetrak
Copy link
Copy Markdown
Member Author

Gpetrak commented Apr 8, 2026

@Gpetrak I suspect this won't cover the cases where the URL includes parameters. As an example this WMS service requires the custom map parameter to work. the https://www502.regione.toscana.it/ows_ofc/com.rt.wms.RTmap/wms?map=owsofc&

@giohappy , I saw that get_cleaned_url_params clears the standard parameters like service , version, etc and I thought that base_url was enough. But indeed we don't cover such cases. I updated the PR accordingly and now this case is covered too.

@mattiagiupponi mattiagiupponi merged commit 88861e5 into master Apr 10, 2026
16 checks passed
@mattiagiupponi mattiagiupponi deleted the ISSUE_14111 branch April 10, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Harvester lookup failure caused by trailing ? during the remote resource upload through the API

4 participants