Skip to content

[Fixes #13997] Fixes Custom license saved without identifier#14094

Draft
sijandh35 wants to merge 2 commits intomasterfrom
ISSUE_13997
Draft

[Fixes #13997] Fixes Custom license saved without identifier#14094
sijandh35 wants to merge 2 commits intomasterfrom
ISSUE_13997

Conversation

@sijandh35
Copy link
Copy Markdown
Contributor

Fixes #13997

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Apr 3, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an automated identifier generation for the License model by overriding the save method to assign a UUID if one is missing. The review feedback suggests using the string representation of the UUID instead of the hex format to ensure consistency with other models in the project.

@sijandh35 sijandh35 assigned sijandh35 and unassigned sijandh35 Apr 3, 2026
@sijandh35 sijandh35 self-assigned this Apr 3, 2026
@sijandh35 sijandh35 requested a review from mattiagiupponi April 3, 2026 11:17
@sijandh35 sijandh35 marked this pull request as draft April 3, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom license saved without identifier -> Not usable in metadata form

2 participants