Move to geny organisation #39
Conversation
|
@caarmen if you have some time to check my bad english in the readme, that would be great ;-) As discussed, I summon the OpenSource Master, @mmaret-geny @fbarthelery @rgottschalk is the apache license correctly applied? |
|
|
||
| You can see your PR from Slack. | ||
|
|
||
| You need to add a "slash command" in the slack settings (for eg "/pr") |
There was a problem hiding this comment.
Can you specify the steps to get to the specific screen in slack to configure it?
There was a problem hiding this comment.
You can say to open this url: https://mydomain.slack.com/services/new/slash-commands
|
Thank you @caarmen for all your feedbacks |
rename variable, doc, remove useless files, ... use of pylint (in default configuration) to find mistake
Thx Carmen for the screenshot :-)
github icon 404 for now, but it should be the correct place in a few days genymobile go to the blog (should be the most intersting place for gm_pr user and it is easy to learn about genymobile from here) Writting a footer took a few hours of my life. After visiting all the internet (twice) I found this link and I like to thanks this guy: http://stackoverflow.com/questions/3443606/make-footer-stick-to-bottom-of-page-correctly/18066619#18066619
fix html mistake use django comment for license, this avoid license duplication with inclusion
|
LGTM |
|
❌ You did not add headers on some |
|
Also it will be good to provide a setup.py file to package your web and gm_pr django applications |
|
thx @fbarthelery header added in the last commit |
|
LGTM |
| Then you need to add a incoming-webhook to let the bot send messages to Slack: | ||
|
|
||
| * Open https://mydomain.slack.com/services/new/incoming-webhook | ||
| * Choose a channel (the bot will be able to override it, so the choice do |
There was a problem hiding this comment.
so the choice do not matter -> so it doesn't really matter what you enter
|
LGTM |
Move to geny organisation fixes #30
This PR will hopefully fixes #30