Skip to content

Figure.directional_rose/Figure.magnetic_rose: Fix compatibility with upcoming GMT 6.7.0 #4729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seisman wants to merge 3 commits into
base: main
Choose a base branch
from
+4 −4
Open

Figure.directional_rose/Figure.magnetic_rose: Fix compatibility with upcoming GMT 6.7.0 #4729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ab0ecb
Figure.directional_rose/Figure.magnetic_rose: Fix compatibility with …
seisman Jul 17, 2026
2bd166e
Revert "Figure.directional_rose/Figure.magnetic_rose: Fix compatibili…
seisman Jul 17, 2026
badaee8
Figure.directional_rose/Figure.magnetic_rose: Fix compatibility with …
seisman Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pygmt/src/directional_rose.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,10 @@ def directional_rose(

# The default position is set to "TR" since GMT 6.7.0, which has no default value
# in GMT 6.6.0 and earlier versions.
# TODO(GMT>6.6.0): Set 'default=None' after GMT 6.7.0.
# TODO(GMT>6.6.0): Set 'default=True' after GMT 6.7.0.
position = _parse_position(
position,
default=None
default=True # Use GMT default position but need to set to True to activate -Td
if Version(__gmt_version__) > Version("6.6.0")
else Position("TR", cstype="inside"),
)
Expand Down
4 changes: 2 additions & 2 deletions pygmt/src/magnetic_rose.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,10 @@ def magnetic_rose( # noqa: PLR0913

# The default position is set to "TR" since GMT 6.7.0, which has no default value
# in GMT 6.6.0 and earlier versions.
# TODO(GMT>6.6.0): Set 'default=None' after GMT 6.7.0.
# TODO(GMT>6.6.0): Set 'default=True' after GMT 6.7.0.
position = _parse_position(
position,
default=None
default=True # Use GMT default position but need to set to True to activate -Tm
if Version(__gmt_version__) > Version("6.6.0")
else Position("TR", cstype="inside"),
)
Expand Down
Loading