Skip to content

Add new exception GMTValueError for invalid values #3985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add new exception GMTValueError for invalid values #3985

wants to merge 2 commits into from
+213 −143

Conversation

seisman
Copy link
Member

@seisman seisman commented Jun 20, 2025 •
edited
Loading

Add new exception GMTValueError. The error message will be like

Invalid value: 'xxx'. Expected one of: "a", "b", 0, 1. Detailed reasons explaining why it's invalid.

Address #3984 and #3707.

@seisman seisman added the enhancement Improving an existing feature label Jun 20, 2025
@seisman seisman mentioned this pull request Jun 20, 2025
Open
@seisman seisman force-pushed the exception/valueerror branch 2 times, most recently from ddf56de to efa6715 Compare June 21, 2025 04:15
@seisman seisman changed the title POC: Add custom exception GMTValueError POC: Add new exception GMTValueError for invalid values Jun 21, 2025
@seisman seisman force-pushed the exception/valueerror branch 15 times, most recently from 340b235 to 8472d86 Compare June 23, 2025 05:01
@seisman seisman marked this pull request as ready for review June 23, 2025 05:31
@seisman seisman changed the title POC: Add new exception GMTValueError for invalid values Add new exception GMTValueError for invalid values Jun 23, 2025
@seisman seisman added this to the 0.17.0 milestone Jun 23, 2025
@seisman seisman force-pushed the exception/valueerror branch from 8472d86 to a590758 Compare June 24, 2025 02:27
@seisman seisman added the needs review This PR has higher priority and needs review. label Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Improving an existing feature needs review This PR has higher priority and needs review.
Projects
None yet
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.
1 participant
@seisman