Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
fhennig
force-pushed
the
generalized-collections-ui-pt1
branch
from
8bf2b3d to
6c84134
Compare
fhennig
force-pushed
the
generalized-collections-ui-detail-view
branch
from
cd5ab56 to
c5d8a57
Compare
fhennig
force-pushed
the
generalized-collections-ui-pt1
branch
from
6c84134 to
aaa7e7d
Compare
fhennig
force-pushed
the
generalized-collections-ui-detail-view
branch
from
c5d8a57 to
62f60ad
Compare
fhennig
force-pushed
the
generalized-collections-ui-detail-view
branch
from
62f60ad to
c560f43
Compare
- Add viewCollection route to pages.ts - Add clickable rows to CollectionsOverview linking to detail page - Add CollectionDetail component (read-only, shows variants) - Add [organism]/[id]/index.astro page with breadcrumbs and session-based userId Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Use plain h2 for variants section in CollectionDetail Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
fhennig
force-pushed
the
generalized-collections-ui-detail-view
branch
from
c560f43 to
4adeee1
Compare
- Show organism label (e.g. 'SARS-CoV-2') instead of raw key in detail page - Render lineage fields (catchall string entries) in filter object variants - Remove variant type badge since the type is implied by the shown properties - Use 'Collection #<id>' for page title and breadcrumb - Add browser spec for CollectionDetail covering success and error states - Add mockGetCollection to AstroApiRouteMocker Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Move data fetching from client-side React (useQuery) to Astro frontmatter, enabling the real collection name in the title/breadcrumb at render time and eliminating the loading spinner. 404s redirect; other errors show an inline message. CollectionDetail becomes a pure renderer accepting a collection prop. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…owser spec The collection detail is now server-rendered so the browser spec and the astro route mock for fetching a single collection are no longer needed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Drop the separate fetchError boolean; check collection !== undefined directly in the template, which TypeScript narrows correctly without a non-null assertion. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add FILTER_OBJECT_ARRAY_FIELD_LABELS map and getLineageFields() to Collection.ts as the single source of truth for known filter object keys. Simplify FilterObjectVariantDetails to iterate over known fields explicitly, removing the duplicated key/label arrays and the non-null assertion. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
To be changed:
|
Variants in the collection detail view are now displayed in a table with Name, Description, Query, Total, Last 30d, and Last 90d columns. Counts are fetched client-side from LAPIS using React Query. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds Page.singleVariantView(organism, variant) to the Page helpers and uses it to make variant names in the collection detail table link to the single-variant analysis page with the variant filter pre-populated. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
Needs a bit of testing:
Would be nice to have automated testing for that, probably. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenshot
PR Checklist
All necessary documentation has been adapted.The implemented feature is covered by an appropriate test.