Skip to content

fix(lapis): set a low timeout on calling SILO info so that the health endpoint doesn't block if SILO doesn't respond #1593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fengelniederhammer wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(lapis): set a low timeout on calling SILO info so that the health endpoint doesn't block if SILO doesn't respond #1593

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lapis/src/main/kotlin/org/genspectrum/lapis/silo/SiloClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import java.net.http.HttpClient
import java.net.http.HttpRequest
import java.net.http.HttpResponse
import java.net.http.HttpResponse.BodyHandlers
import java.time.Duration
import java.util.concurrent.Executors
import java.util.stream.Stream

Expand Down Expand Up @@ -139,7 +140,14 @@ open class CachedSiloClient(
}

fun callInfo(): InfoData {
val response = send(siloUris.info, BodyHandlers.ofString(), ::tryToReadSiloErrorFromString) { it.GET() }
val response = send(
uri = siloUris.info,
bodyHandler = BodyHandlers.ofString(),
tryToReadSiloErrorFromBody = ::tryToReadSiloErrorFromString,
) {
it.timeout(Duration.ofMillis(100)) // this should never take long, make sure we don't block anything else
it.GET()
}

return InfoData(
dataVersion = getDataVersion(response),
Expand Down