change plugin theme and add UIkit default theme

[ivywe]

Hi,

All of plugin theme have UIkit style.
UIkit default theme 'Default'.

I checked HTML by using validator.w3.org.

• Responsive Web Design
• HTML5
• CSS3

removed table layout and some deprecated HTML
<b>, width="***",

[eSilverStrike]

Wow that is a lot of work. Thanks Ivy.

@dengenxp - How should we handle this? I think we should make the denim theme the default theme for Geeklog so I don't mind moving the denim/uikit related files to the default plugin template directory. I don't think we should loose the plugin theme files for modern curve and other similar themes that don't use uikit. We should either keep the original default plugin template files and put them in a modern_curve directory or even keep the original denim plugin template files since they are not based on uikit and put them in the modern_curve directory.

What ever we decide on we will have to add a functions.php file to each of the plugin temple directories (see forum for an example) that use uikit so the plugin will tell Geeklog to load uikit if the theme Geeklog is using, is not.

I also notice that Ivy has done some changes to plugins/calendar/functions.inc. We should remove that html from the code and put it into a calendar template file.

Does that make sense dengen? Do you think we should do it another way?

[hostellerie]

ok to make the denim theme the default theme for Geeklog

Ben

2016-02-10 21:16 GMT+01:00 Tom [email protected]:

Wow that is a lot of work. Thanks Ivy.

@dengenxp https://github.com/dengenxp - How should we handle this? I
think we should make the denim theme the default theme for Geeklog so I
don't mind moving the denim/uikit related files to the default plugin
template directory. I don't think we should loose the plugin theme files
for modern curve and other similar themes that don't use uikit. We should
either keep the original default plugin template files and put them in a
modern_curve directory or even keep the original denim plugin template
files since they are not based on uikit and put them in the modern_curve
directory.

What ever we decide on we will have to add a functions.php file to each of
the plugin temple directories (see forum for an example) that use uikit so
the plugin will tell Geeklog to load uikit if the theme Geeklog is using,
is not.

I also notice that Ivy has done some changes to
plugins/calendar/functions.inc. We should remove that html from the code
and put it into a calendar template file.

Does that make sense dengen? Do you think we should do it another way?

—
Reply to this email directly or view it on GitHub
#662 (comment).

[ivywe]

Hi,

Theme "Default" is based on Denim. and using style.css.php of Modern Curve.
"Denim" is very excellent theme using UIkit and Stylus.
"Default" is the most simple theme by using UIkit and few Geeklog style based on Denim.
Pagination, Breadcrumb, Panel, Form, so many UIkit style

Default theme name is Default.
It is simple rule for anyone, I think.

@dengenxp, I am happy if you get "Default" partially into "Denim".
and rename Denim to Default.

I changed calendar/functions.php and system/lib-comment.php.

• remove deprecated html tags
• add UIkit
• add <li> and remove separator text "|" for UIkit template.

If all theme include UIkit, Geeklog can be change modern cms.

[ivywe]

Tom,

It's simple to link UIkit for all theme.
Please Modern Curve link UIkit.

Professional is very classical table layout theme.
Professional theme design passed down to Denim.

Many user want RWD and HTML5 theme.

[eSilverStrike]

True but not all of our users use a uikit based theme. Plugins now have the ability to include scripts and other files via their own functions.php. I was just saying these need to be added just in case someone uses a theme that doesn't use uikit directly. This way the plugins can include uikit when needed.

[eSilverStrike]

I am hesitant to have the plugin default templates include any classes from uikit. The default theme should be as simple as possible and be allowed to work with the greatest number of themes out there (both old and new).

Who knows maybe someone will want to make a Geeklog theme that uses bootstrap. I am sure this person wouldn't really want to have the plugins loading in uikit. That would be a resource hog and would probably create some conflicts.

Then again Geeklog has chosen uikit as the framework we will be using going forward. What does everyone else think? Should the default plugin templates use uikit along with the denim plugin templates which I assume we will still be including?

[ivywe]

Bootstrap does not conflict width UIkit.
UIkit class "uk-" always added.
Bootstrap conflict with Geeklog style "tooltip" and some style.

This site use UIkit and Bootstrap, both.
http://www.hananokumo.com

UIkit is very light and simple framework.
So we can use double frameworks.

Some CMS include Bootstrap.
Geeklog should include some front-end framework.

or Geeklog-UIkit branch.

deprecated tag / attribute
http://www.codehelp.co.uk/html/deprecated.html

[eSilverStrike]

Ivy we are misunderstanding each other. Uikit is the framework we have chosen for Geeklog. Geeklog's Main theme should use uikit.

I am not saying we should use anything else.

[ivywe]

Okay.

1. calendar/functions.inc
   change deprecated tag / attribute
   http://www.codehelp.co.uk/html/deprecated.html
   example)
   from:
   <b>
   to:
   style="font-weight:bold"
2. lib-comment.php
   add theme variable not include separator "|"

[hostellerie]

The site http://www.hananokumo.com only displays
[_header_navigation_en:]
[footer_contents_en:]

[ivywe]

thanks.

http://www.hananokumo.com
maybe mistake multi language setting.
Please check again.

[hostellerie]

@ivywe display is the same

[_header_navigation_en:]
[footer_contents_en:]

See attachment
http www.hananokumo.com#undefined.txt

[ivywe]

Okay, thanks!
I will discard multi language mode.

[ivywe]

Please check again.
http://www.hananokumo.com

[hostellerie]

Ok it displays nice

[ivywe]

thanks!