Skip to content

Commit

Permalink
Force specific Maven version for plugin modules, rather than just usi…
Browse files Browse the repository at this point in the history
…ng the default version on the ubuntu-latest runner. Currently GATE plugins will not build with Maven 3.9 so this protects us in case the ubuntu-latest runner is upgraded in future.
  • Loading branch information
ianroberts committed Nov 24, 2023
1 parent 9478652 commit 4afde72
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 0 deletions.
10 changes: 10 additions & 0 deletions .github/workflows/standard-module-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ on:
default: true
required: false
type: boolean
maven_version:
description: "Version of Maven to use for the build"
default: "3.8.8"
required: false
type: string

jobs:
build:
Expand All @@ -42,6 +47,11 @@ jobs:
distribution: ${{ inputs.java_distribution }}
cache: maven

- name: Set up Maven
uses: stCarolas/[email protected]
with:
maven-version: ${{ inputs.maven_version }}

# Override http://repo.gate.ac.uk to use https:// instead
- name: Configure Maven settings
uses: whelk-io/maven-settings-xml-action@v21
Expand Down
10 changes: 10 additions & 0 deletions .github/workflows/standard-module.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ on:
default: "1"
required: false
type: string
maven_version:
description: "Version of Maven to use for the build"
default: "3.8.8"
required: false
type: string

# Sets permissions of the GITHUB_TOKEN to allow deployment to GitHub Pages
permissions:
Expand Down Expand Up @@ -77,6 +82,11 @@ jobs:
distribution: ${{ inputs.java_distribution }}
cache: maven

- name: Set up Maven
uses: stCarolas/[email protected]
with:
maven-version: ${{ inputs.maven_version }}

# Override http://repo.gate.ac.uk to use https:// instead
- name: Configure Maven settings
uses: whelk-io/maven-settings-xml-action@v21
Expand Down

0 comments on commit 4afde72

Please sign in to comment.