Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: RenderTexture's draw and drawBundled methods threw exceptions if context was lost. #642

Closed

Conversation

stepan-beresnev
Copy link

It's basically the same issue as was discussed here 627.

@PrimaryFeather
Copy link
Contributor

Thanks! I'll look into the complete "context" issue after the release of Starling 1.6.

@PrimaryFeather
Copy link
Contributor

Since this is a small change that shouldn't have any side effects, I changed my mind and added it right away. Thanks again!

Oldes pushed a commit to Oldes/Starling-Framework that referenced this pull request Dec 3, 2014
@stepan-beresnev
Copy link
Author

Hello,

Not sure, if you did it intentionally, but you didn't copy
if (!Starling.current.contextValid) return;
on the top of RenderTexture's render function.

@PrimaryFeather
Copy link
Contributor

That's intentional! "render" will never be called alone; it's always called from within "renderBundled". So it's enough to check the context in the latter method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants