fix: Set TERM=screen for all non-interactive tmux calls#4860
Open
silasjmatson wants to merge 1 commit intoGameServerManagers:developfrom
Open
fix: Set TERM=screen for all non-interactive tmux calls#4860silasjmatson wants to merge 1 commit intoGameServerManagers:developfrom
silasjmatson wants to merge 1 commit intoGameServerManagers:developfrom
Conversation
When connected to a server via ssh, and the server doesn't have the
proper terminfo, tmux will fail with 'unsupported terminal' errors.
These errors are not surfaced by the scripts, e.g. details, start,
stop, so they result in either silent failures or don't work at all.
e.g. `./mcserver details` on my server showed 0% CPU, 0% Memory,
and STOPPED for the server status when the server was
actually running. This was because the tmux calls to get
this info failed.
The root cause of this was that I was connected to my server
via kitty, a terminal emulator that my server did not have
terminfo for.
This can be resolved via running `infocmp -x xterm-kitty | ssh
YOUR-SERVER -- tic -x -` and replacing `xterm-kitty` with whatever
is appropriate, or by setting TERM=xterm-256color in the ssh config,
but that is not obvious to do when presented with silent failures.
This commit sets TERM=screen for all non-interactive tmux calls,
which resolves the issue. Note that the `console` command does not
set this, as that is an interactive shell, and the user's terminfo
should be passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When connected to a server via ssh, and the server doesn't have the
proper terminfo, tmux will fail with 'unsupported terminal' errors.
These errors are not surfaced by the scripts, e.g. check_status,
so they result in either silent failures or don't work at all.
This can be resolved via running
infocmp -x xterm-kitty | ssh YOUR-SERVER -- tic -x -and replacing
xterm-kittywith whatever is appropriate, or by settingTERM=xterm-256color in the ssh config, but that is not obvious to do
when presented with silent failures.
This commit sets
TERM=screenfor all non-interactive tmux calls,which resolves the issue. Note that the
consolecommand does notset this, as that is an interactive shell, and the user's terminfo
should be passed.
Pastebin log demonstrating the issue with ghostty terminal: https://pastebin.com/JeAVUfk4
Fixes: #4861
Type of change
Checklist
PR will not be merged until all steps are complete.
developbranch as its base.Documentation
If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.
Thank you for your Pull Request!