Add terminate method to process class that sends SIGTERM #2629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peace-maker
requested changes
Oct 7, 2025
| self.proc.terminate() | ||
| else: | ||
| # On Unix-like systems, send SIGTERM | ||
| os.kill(self.pid, signal.SIGTERM) |
There was a problem hiding this comment.
I don't think we need this distinction since os.terminate is documented to send SIGTERM on posix-like systems. So we can just call terminate disregarding the host os
| return | ||
|
|
||
| # Check if process is still running | ||
| if self.poll() is not None: |
There was a problem hiding this comment.
The poll check should be done afterwards to detect if the process exited immediately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a terminate() method to the process class that sends SIGTERM instead of SIGKILL. This provides a more graceful way to stop processes, allowing them to clean up and exit properly. Resolves #2515.