Invisible Item Frames WorldGuard #86
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added flags for WorldGuard to allow/disallow users to change invisibility of item frames. This is helpful for protected regions.
Added a check if a player is able to bypass the protection.
josefbaltz
requested changes
Dec 11, 2023
garrettsummerfi3ld
added a commit
that referenced
this pull request
Dec 11, 2023
Resolves a comment on PR #86
Previously the plugin would throw a ClassCastException when trying to cast a WorldGuard region to a World. This was due to checking if the player had a bypass check and directly casting a normal player to the location, rather than WorldGuard's LocalPlayer. This wasn't documented well from WorldGuard's side, but it is now fixed. Fixed issue where on startup the plugin would throw an error due to the entirety of the plugin had WorldGuard embedded into it, rather than just the WorldGuard dependency. This is now fixed. Removed a maven repository due to it conflicting with other dependencies being used.
Resolves a comment on PR #86
garrettsummerfi3ld
force-pushed
the
feature/worldguard-flags
branch
from
3069fbf to
a93fd09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information
Add WorldGuard functionality for Invisible Item Frames. Such as disabling toggling them on/off in a specified region.
Demonstration
This is the test region for the flags.
There is a specified flag that can be used to deny changing Item Frames in a region.
If you do not have the standard WorldGuard bypass permission node, you cannot change the item frame and a message is thrown to the user.