Skip to content
This repository has been archived by the owner on Aug 6, 2024. It is now read-only.

Drop python 3.7 #64

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Drop python 3.7 #64

wants to merge 9 commits into from

Conversation

nstarman
Copy link
Collaborator

Signed-off-by: Nathaniel Starkman (@nstarman) [email protected]

To match astropy.

PR Checklist

  • Check out the contributing guidelines and code of conduct
  • Check out the contributing workflow ( for a practical example click here )
  • Give a detailed description of the PR above.
  • Document changes in the CHANGES.rst file. See existing changelog for examples.
  • Add tests, if applicable, to ensure code coverage never decreases.
  • Make sure the docs are up to date, if applicable, particularly the docstrings and RST files in docs folder.
  • Ensure linear history by rebasing, when requested by the maintainer.

Signed-off-by: Nathaniel Starkman (@nstarman) <[email protected]>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Signed-off-by: Nathaniel Starkman (@nstarman) <[email protected]>
@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #64 (7665361) into main (3b17b6e) will decrease coverage by 16.04%.
The diff coverage is 58.06%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #64       +/-   ##
===========================================
- Coverage   88.28%   72.23%   -16.05%     
===========================================
  Files          33       33               
  Lines        1673     1675        +2     
===========================================
- Hits         1477     1210      -267     
- Misses        196      465      +269     
Impacted Files Coverage Δ
discO/core/__init__.py 100.00% <ø> (ø)
discO/core/common.py 100.00% <ø> (ø)
discO/core/pipeline.py 87.78% <ø> (ø)
discO/plugin/__init__.py 55.55% <ø> (-22.23%) ⬇️
discO/plugin/agama/__init__.py 0.00% <ø> (ø)
discO/plugin/agama/fitter.py 0.00% <0.00%> (ø)
discO/plugin/agama/sample.py 0.00% <0.00%> (ø)
discO/plugin/agama/type_hints.py 0.00% <ø> (ø)
discO/plugin/agama/wrapper.py 0.00% <ø> (ø)
discO/plugin/gala/__init__.py 0.00% <ø> (-100.00%) ⬇️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b17b6e...7665361. Read the comment docs.

Signed-off-by: Nathaniel Starkman (@nstarman) <[email protected]>
@nstarman nstarman changed the title increase line length to 100 Drop python 3.7 Sep 11, 2021
Signed-off-by: Nathaniel Starkman (@nstarman) <[email protected]>
@nstarman nstarman force-pushed the cleanup branch 2 times, most recently from 3d1bc6a to ad9d12e Compare September 11, 2021 18:31
Signed-off-by: Nathaniel Starkman (@nstarman) <[email protected]>
Signed-off-by: Nathaniel Starkman (@nstarman) <[email protected]>
Signed-off-by: Nathaniel Starkman (@nstarman) <[email protected]>
Signed-off-by: Nathaniel Starkman (@nstarman) <[email protected]>
@nstarman nstarman force-pushed the cleanup branch 10 times, most recently from 00df8f4 to f127f5f Compare September 12, 2021 07:03
Signed-off-by: Nathaniel Starkman (@nstarman) <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant