Add manual public GraphQL schema reload#49
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThis PR implements a complete manual GraphQL schema reload system. Operators can now rebuild and atomically swap the public ChangesManual GraphQL Schema Reload
🎯 4 (Complex) | ⏱️ ~60 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@internal/graphql/admin/resolvers.go`:
- Around line 631-642: The normalization currently trims overall NSID and checks
for empty segments but still allows segments that contain internal whitespace
(e.g., "app. test.foo"); update normalizeRequestedLexiconNSID to reject any
segment that contains internal whitespace characters by checking each part for
whitespace (e.g., compare part to strings.TrimSpace(part) or test for any \t\n\r
or space using strings.ContainsAny or a \s regexp) and return the same formatted
validation error when such whitespace is found; keep the function name
normalizeRequestedLexiconNSID and the existing error message.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 3bc49a60-313c-4619-b8c9-ca65a81b01a1
📒 Files selected for processing (34)
.changes/unreleased/add-manual-schema-reload-ui.yaml.changes/unreleased/reject-invalid-admin-lexicons.yamlAGENTS.mdREADME.mdclient/README.mdclient/src/app/lexicons/page.tsxclient/src/app/onboarding/page.tsxclient/src/lib/graphql/mutations.test.tsclient/src/lib/graphql/mutations.tsclient/src/lib/graphql/schema-reload.test.tsclient/src/lib/graphql/schema-reload.tscmd/hyperindex/main.gocmd/hyperindex/main_test.godocs/manual-schema-reload-plan.mdinternal/graphql/admin/handler_test.gointernal/graphql/admin/resolvers.gointernal/graphql/admin/resolvers_lexicons_test.gointernal/graphql/admin/resolvers_reload_schema_test.gointernal/graphql/admin/schema.gointernal/graphql/admin/types.gointernal/graphql/handler.gointernal/graphql/handler_test.gointernal/graphql/schema_manager.gointernal/graphql/schema_manager_test.gointernal/graphql/subscription/handler.gointernal/graphql/subscription/handler_test.gomanual-schema-reload-context/gon-60-validation.mdmanual-schema-reload-context/gon-61-admin-mutation.mdmanual-schema-reload-context/gon-62-handler-provider.mdmanual-schema-reload-context/gon-63-frontend-docs.mdoracle/manual-schema-reload-plan-review.mdplans/manual-schema-reload-linear-created.jsonplans/manual-schema-reload-linear-issues.jsontests/api-smoke/README.md
💤 Files with no reviewable changes (1)
- AGENTS.md
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13f6502a76
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…-reload # Conflicts: # cmd/hyperindex/main.go
|
(reply generated by OpenAI Codex) Checked the PR-level comments and review summaries:
|
1 participant
Summary
reloadSchemamutation and wire it into public HTTP/WS GraphQL handlersValidation
npm --prefix client run testnpm --prefix client run lintnpm --prefix client run buildgo build -v ./...DATABASE_URL=sqlite::memory: go test -v -race ./internal/graphql/... ./cmd/hyperindexgit diff --checkManual Tap/client validation
TAP_SIGNAL_COLLECTION=app.certified.actor.profileTAP_COLLECTION_FILTERS=app.certified.*,org.hypercerts.*TAP_ENABLED=true/lexiconsto uploadapp.certified.actor.profile, reload the schema, and confirm the UI success stateappCertifiedActorProfileafter reloadapp.certified.actor.profilerecords successfullycollectionStats: 34 collections, 0 outside the configured Tap filtersSummary by CodeRabbit
Release Notes
New Features
Bug Fixes
Documentation