refactor Drums, #55
Open
refactor Drums, #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrombread
reviewed
Nov 8, 2025
src/main/java/com/fouristhenumber/utilitiesinexcess/common/blocks/BlockDrum.java
Outdated
Show resolved
Hide resolved
danyadev
previously requested changes
Nov 8, 2025
src/main/java/com/fouristhenumber/utilitiesinexcess/common/blocks/BlockDrum.java
Outdated
Show resolved
Hide resolved
src/main/java/com/fouristhenumber/utilitiesinexcess/common/blocks/BlockDrum.java
Outdated
Show resolved
Hide resolved
src/main/java/com/fouristhenumber/utilitiesinexcess/common/blocks/BlockDrum.java
Outdated
Show resolved
Hide resolved
src/main/java/com/fouristhenumber/utilitiesinexcess/common/blocks/BlockDrum.java
Outdated
Show resolved
Hide resolved
Member
|
Love the IFluidContainerItem support, but... I tried to fill a drum while holding a stack of Certus Quartz Tanks with 16000L water and they all just gone tank.-.drum.mp4 |
Contributor
…Excess into kath/fix-drums
Contributor
Contributor
Spicierspace153
force-pushed
the
kath/fix-drums
branch
from
8e67beb to
8b936a8
Compare
SuperSoupr
requested changes
Dec 14, 2025
Contributor
SuperSoupr
left a comment
SuperSoupr
left a comment
There was a problem hiding this comment.
Mostly nits but some fixes needed as well, otherwise LGTM 👍
src/main/java/com/fouristhenumber/utilitiesinexcess/common/blocks/BlockDrum.java
Outdated
Show resolved
Hide resolved
src/main/java/com/fouristhenumber/utilitiesinexcess/common/blocks/BlockDrum.java
Outdated
Show resolved
Hide resolved
src/main/java/com/fouristhenumber/utilitiesinexcess/common/blocks/BlockDrum.java
Outdated
Show resolved
Hide resolved
src/main/java/com/fouristhenumber/utilitiesinexcess/common/blocks/BlockDrum.java
Outdated
Show resolved
Hide resolved
src/main/java/com/fouristhenumber/utilitiesinexcess/common/blocks/BlockDrum.java
Outdated
Show resolved
Hide resolved
src/main/java/com/fouristhenumber/utilitiesinexcess/common/blocks/BlockDrum.java
Outdated
Show resolved
Hide resolved
src/main/java/com/fouristhenumber/utilitiesinexcess/common/blocks/BlockDrum.java
Outdated
Show resolved
Hide resolved
src/main/java/com/fouristhenumber/utilitiesinexcess/common/tileentities/TileEntityDrum.java
Outdated
Show resolved
Hide resolved
Contributor
FourIsTheNumber
pushed a commit
that referenced
this pull request
Dec 15, 2025
SuperSoupr
reviewed
Dec 15, 2025
Comment on lines
8
to
15
| public class DrumConfig { | ||
|
|
||
| @Config.DefaultBoolean(true) | ||
| @Config.Comment("Change it to MB vs L's") | ||
| public static boolean unitToDisplay; | ||
|
|
||
| } |
Contributor
There was a problem hiding this comment.
Sorry I didn't think of this before but can you add a config for the size of the regular and bedrockium drums?
Spicierspace153
force-pushed
the
kath/fix-drums
branch
from
a69c1e1 to
89550df
Compare
Contributor
SuperSoupr
reviewed
Dec 15, 2025
src/main/java/com/fouristhenumber/utilitiesinexcess/common/blocks/BlockDrum.java
Show resolved
Hide resolved
Comment on lines
+74
to
+78
| player.addChatComponentMessage( | ||
| new ChatComponentTranslation( | ||
| "%s %s", | ||
| NumberFormat.DEFAULT.format(drumTank.getFluidAmount()), | ||
| DrumConfig.unitToDisplay ? "mB" : "L")); |
Contributor
There was a problem hiding this comment.
Why ChatComponentTranslation? you aren't giving it a translation key...
either make it a translation key or replace with ChatComponentText
also the formatter puts a q after the number if it's 0 for some reaons
src/main/java/com/fouristhenumber/utilitiesinexcess/common/blocks/BlockDrum.java
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
I don't know how to fix this, but there is a desync between the client and server here. The client doesn't get told how full the drum is when it's loaded. Not sure of how impactful this is but the onBlockActivated logic is wrong on the client because of it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drums w/ buckets now work as intended in every single way