Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routed Settings on Main Page #17

Open
wants to merge 3 commits into
base: ios
Choose a base branch
from
Open

Routed Settings on Main Page #17

wants to merge 3 commits into from

Conversation

rikkikendall
Copy link
Contributor

No description provided.

Copy link
Collaborator

@mafuvadze mafuvadze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just touch up a few syntax stuff and double check that all your imports are used. Great work!!

import React, {Component} from 'react';
import {
Modal,
DatePickerIOS,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have a date picker? isn't the modal just gonna have read only information about the shift?

Comment on lines +34 to +35
StartDate: new Date(),
EndDate: new Date(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be consistent in your naming scheme. Always use camelCase

import {StyleSheet, View, Image, Text} from 'react-native';
import {Card, Divider} from 'react-native-elements';
import {CalendarModal} from './CalendarModal';
import { WeatherWidget } from 'react-native-weather';

export default class Dashboard extends Component {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to Vinit, we won't have a Dashboard component, so remove for now :(

title: 'GTHC',
headerRight: () => (
<Icon.Button
backgroundColor={mainHeader.headerStyle.backgroundColor}
name="ios-settings"
size={24}
color="white"
onPress={() => navigation.navigate('Settings')}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants