Modernize plugin registration vars #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see SchedMD/slurm@db69713 Co-authored-by: @dennisklein
dennisklein
force-pushed
the
fix-plugin-registration-vars
branch
from
040f130
to
b51a2ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see SchedMD/slurm@db69713
@michaelmayer2 Thank you very much for contributing this patch! I took the liberty and kept the type of
plugin_versionasunsigned intto match the registration macro in<slurm/spank.h>. Let me know, if you have any objections.Besides that, we have decided to move the repo to github to simplify future collaboration. Over the course of the next days or so I will also add some CI actions and fix the broken links in the readme file.