Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module tests #48

Merged
merged 14 commits into from
Jun 27, 2024
Merged

Add module tests #48

merged 14 commits into from
Jun 27, 2024

Conversation

rahearn
Copy link
Contributor

@rahearn rahearn commented Jun 18, 2024

closes #15

Adds tests for all of the existing modules, attempting to exercise all outputs and input variables.

Only the s3 module is actually creating real infrastructure. The rest of the modules are mocking the cloudfoundry provider to speed test runs significantly and enable testing modules that require either multiple spaces or more memory than we can dedicate to CI runs.

@rahearn rahearn requested review from mogul, asteel-gsa and a team June 18, 2024 02:23
Copy link
Contributor

@mogul mogul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start! Looking forward to seeing how this develops.

.terraform-version Show resolved Hide resolved
@asteel-gsa
Copy link
Contributor

Very cool! This looks awesome!

anna-m-gsa
anna-m-gsa previously approved these changes Jun 18, 2024
@rahearn rahearn marked this pull request as ready for review June 18, 2024 20:35
@rahearn rahearn requested review from anna-m-gsa, mogul and a team June 18, 2024 20:35
pauldoomgov
pauldoomgov previously approved these changes Jun 27, 2024
Copy link
Contributor

@pauldoomgov pauldoomgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One non-blocking suggestion. This is really great! Making Terraform testable with native capabilities is so much slicker than alternatives!

README.md Show resolved Hide resolved
Co-authored-by: Paul Hirsch <[email protected]>
Copy link
Contributor

@pauldoomgov pauldoomgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rahearn rahearn merged commit f841b60 into main Jun 27, 2024
18 checks passed
@rahearn rahearn deleted the test-modules branch June 27, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create module tests
5 participants