Expose canScroll states in PDFReaderState #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JBayangosB
changed the title
|
Changed branch to merge into master as it appeared develop was out of date. Feel free to adjust if needed! |
Unfortunately the pagerState properties that make the most sense for canScrollForward/Backward are currently hardcoded to true and offer no value. Using logic based on record current page and page count instead for the time being with comments explaining the weirdness.
derohimat
approved these changes
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to
PDFReaderStatethat exposes thecanScrollForwardandcanScrollBackyardproperties frompagerStateforHorizontalPDFReaderStateandlazyListStateforVerticalPDFReaderState.This is particular useful for supporting this issue: #45 as the
currentPageproperty would lead to strange scenarios depending on device size, when used to decide if the PDF reader was scrolled to the bottom or top.Large.font.mp4