-
Notifications
You must be signed in to change notification settings - Fork 451
feat: accept sac_scale=strolling #2149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks a lot for your prompt fix! ❤️
Please note that in case of a change which involves the parsing of OSM tags the corresponding documentation needs to be updated as well 🙈
Also, please consider the minor issue from the comment below.
Cheers! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for accepting the sac_scale=strolling tag in OpenStreetMap data for both pedestrian and hiking routing profiles. The SAC (Swiss Alpine Club) scale is used to classify the difficulty of hiking trails, and "strolling" represents the easiest level.
- Added "strolling" as an acceptable SAC scale value for both PedestrianFlagEncoder and HikingFlagEncoder
- Added test coverage for the new functionality in both encoder test classes
- Updated the CHANGELOG to document this feature addition
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| PedestrianFlagEncoder.java | Added "strolling" to the list of suitable SAC scales |
| HikingFlagEncoder.java | Added "strolling" to the list of suitable SAC scales |
| PedestrianFlagEncoderTest.java | Added test to verify "strolling" SAC scale is accepted |
| HikingFlagEncoderTest.java | Added test to verify "strolling" SAC scale is accepted |
| CHANGELOG.md | Documented the new feature addition |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Adressed both comments, one in the merge from main though^^ I think we can squash and rebase anyways :) |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀



Pull Request Checklist
have been resolved.
[Unreleased] heading.
along with a short description of what it is for, and documented this in the Pull Request (below).
(at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
importer etc.), I have generated longer distance routes for the affected profiles with different options
(avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
points generated from the current live ORS.
If there are differences then the reasoning for these MUST be documented in the pull request.
and why the change was needed.
Fixes # .
Information about the changes
Examples and reasons for differences between live ORS routes, and those generated from this pull request
Required changes to ors config (if applicable)