Refactor/remove v2 requirement #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the error when api_version v1 was highly restrictive. This is removed and requests done with any api_version value. Remove 'useAPIV2Msg' constant There still isn't an option to have no api_Version at all. When running an ors instance on e.g. https://my-page.org/services/directions/ one would have work around and set args.host = 'https://my-page.org' args.api_version = 'services' to build the url correctly and get a valid response.
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #77 +/- ##
==========================================
- Coverage 99.09% 99.08% -0.01%
==========================================
Files 15 15
Lines 331 328 -3
Branches 57 55 -2
==========================================
- Hits 328 325 -3
Misses 3 3
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.