Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(posters): merge GEWISPosterHandler and HubblePosterHandler into new CarouselPosterHandler #39

Merged
merged 8 commits into from
Mar 22, 2025

Conversation

Yoronex
Copy link
Member

@Yoronex Yoronex commented Mar 21, 2025

Description

See GEWIS/aurora-core#86 for an elaborate explanation.

This PR includes:

  • Merging the GEWIS poster handler and Hubble poster handler by parameterizing the GEWIS poster handler and rebranding it to the CarouselPosterHandler.
  • StaticPosterHandler now also using the general poster settings (so the layouts between Static and Carousel are the same).

Related issues/external references

Depends on GEWIS/aurora-core#86.

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Style (Change that do not affect the functionality of the code)

@Yoronex Yoronex force-pushed the chore/refactor-gewis-hubble-poster-layouts branch from 6eb9744 to 4f8293c Compare March 22, 2025 16:25
@Yoronex Yoronex force-pushed the chore/refactor-gewis-hubble-poster-layouts branch from 4f8293c to fbdf448 Compare March 22, 2025 16:43
@Yoronex Yoronex merged commit 2fa5556 into develop Mar 22, 2025
6 checks passed
@Yoronex Yoronex deleted the chore/refactor-gewis-hubble-poster-layouts branch March 22, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant