Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue 3499 #3500

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: issue 3499 #3500

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ebf576
fix issue 3499
Dec 19, 2024
7b04c2d
Merge branch 'develop' into pt/fix-3499
paveltomin Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/coreComponents/constitutive/capillaryPressure/JFunctionCapillaryPressure.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,8 @@ void JFunctionCapillaryPressure::saveConvergedRockState( arrayView2d< real64 con
{
permeability = convergedPermeability[ei][0][2];
}
GEOS_ERROR_IF( permeability < LvArray::NumericLimits< real64 >::epsilon, "Zero permeability in J-function capillary pressure" );
// 9.869233×10−13 is Darcy to sq m factor
GEOS_ERROR_IF( permeability < LvArray::NumericLimits< real64 >::epsilon * 9.869233e-13, "Zero permeability in J-function capillary pressure" );
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this error check even necessary? A zero permeability is a valid number and all underflows are flushed to zero.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a division down here

GEOS/src/coreComponents/constitutive/capillaryPressure/JFunctionCapillaryPressure.cpp

Line 267 in 6ebf576

real64 const porosityOverPermeability = pow( porosityAveragedOverQuadraturePoints, porosityExponent )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CusiniM ?


// here we compute an average of the porosity over quadrature points
// this average is exact for tets, regular pyramids/wedges/hexes, or for VEM
Expand Down
Loading