Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue 3499 #3500

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: issue 3499 #3500

wants to merge 2 commits into from

Conversation

paveltomin
Copy link
Contributor

should fix #3499

@paveltomin paveltomin added type: bug Something isn't working flag: ready for review labels Dec 19, 2024
@paveltomin paveltomin self-assigned this Dec 19, 2024
@paveltomin paveltomin added the flag: no rebaseline Does not require rebaseline label Dec 23, 2024
CusiniM
CusiniM reviewed Dec 31, 2024
View reviewed changes
src/coreComponents/constitutive/capillaryPressure/JFunctionCapillaryPressure.cpp
@@ -250,7 +250,8 @@ void JFunctionCapillaryPressure::saveConvergedRockState( arrayView2d< real64 con
{
permeability = convergedPermeability[ei][0][2];
}
GEOS_ERROR_IF( permeability < LvArray::NumericLimits< real64 >::epsilon, "Zero permeability in J-function capillary pressure" );
// 9.869233×10−13 is Darcy to sq m factor
GEOS_ERROR_IF( permeability < LvArray::NumericLimits< real64 >::epsilon * 9.869233e-13, "Zero permeability in J-function capillary pressure" );
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this error check even necessary? A zero permeability is a valid number and all underflows are flushed to zero.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a division down here

GEOS/src/coreComponents/constitutive/capillaryPressure/JFunctionCapillaryPressure.cpp

Line 267 in 6ebf576

real64 const porosityOverPermeability = pow( porosityAveragedOverQuadraturePoints, porosityExponent )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CusiniM ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CusiniM CusiniM CusiniM left review comments

@dkachuma dkachuma Awaiting requested review from dkachuma dkachuma is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@paveltomin paveltomin

Labels
flag: no rebaseline Does not require rebaseline flag: ready for review type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nonsensical low permeability check in JFunctionCapillaryPressure.cpp
2 participants
@paveltomin @CusiniM