Not merge - QE with spectral functions branch for GENIE review #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he CBF spectral function model
(tightly-peaked distribution leads to very slow rejection sampling) and to look up the data files using its XML configuration. The histograms used to represent the spectral functions are now initialized lazily.
the FreeNucleonTensor class
… used by Noemi's fortran code
…tion for the CBFSpectFuncQELPXSec algorithm
…tions used in Noemi's Fortran code. This will allow a direct comparison for validation purposes.
the CC/NC lepton tensor expression
FreeNucleonTensor.cxx
paper used to write the code is off by a factor of two.
…to a new tune (N19_00a_00_000) and restore the old configuration files in the common area.
bound nucleons. Also silence an unneeded warning message in CBFSpecFuncQELPXSec::XSec.
… free nucleon tensor contraction for EMQE scattering. Also enforce that the hit nucleon invariant mass is positive in the full differential cross section calculation. Switch to using the new QELEventGenerator (as intended) for quasielastic CC, NC, and EM scattering in the N19_00a_00_000 model set.
…s in QELEventGenerator. This sort of thing is now handled by an EM-specific Q^2 cut, which is enforced across multiple reaction modes.
differential cross section search performed in QELEventGenerator::ComputeMaxXSec(). Also fix a couple of minor issues in the CBFSpectFuncQELPXSec class.
N19_00a_00_000 tune. This will cause constant kF values (from the Fermi momentum table) to be used by PauliBlocker, in agreement with Noemi's Fortran calculation.
function data tables as bin centers rather than bin edges. Update the input file format so that it requires only a single pass to parse. Remove call to std::map::at() from SpectralFunc.cxx, since this is a C++11 feature.
definition of the removal energy when using the SpectralFunc nuclear model. Also rename the CBFSpectFuncQELPXSec model to UnifiedQELPXSec.
UnifiedQELPXSec cross section model
…on data files. Also merge in recent changes from the master branch.
classes. Add extra constructors to use for convenience in writing tests.
version of the spectral function file for 12C to the repository.
…de it triggers rootcling errors in some circumstances.
…a new abstract interface (NCELStrangeFormFactorsModelI) that handles calculations of the heavy quark contribution to the form factors (thought to be dominated by strange quarks). Add a derived class called AhrensNCELStrangeFF that implements the NC strange form factors in a way that is equivalent to the Ahrens treatment.
separately-configured value in the DipoleELFormFactorsModel and BBA03ELFormFactorsModel classes.
…inal Jacobian was computed correctly in the hit nucleon rest frame. The proposed new Jacobian, on the other hand, is only valid in a frame (e.g., the CM frame) wherein the final lepton energy is independent of scattering angle. Revert "bug fix in J for the Rosenbluth xsection" This reverts commit fb26255.
genie::utils::BindHitNucleon(). Previously the check would fail when using this model via a NuclearModelMap instance.
… used to test the new SpectralFunc implementation. In Noemi's Fortran code, the value of Mv^2 is set instead of Mv.
…tion histograms. Getting this right is helpful for testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.